Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing remaining optional job --stage=gs://kubernetes-release-pull #33278

Merged
merged 10 commits into from
Aug 9, 2024
Merged

removing remaining optional job --stage=gs://kubernetes-release-pull #33278

merged 10 commits into from
Aug 9, 2024

Conversation

BenTheElder
Copy link
Member

most of what's left for #18789

TODO: pull-kubernetes-e2e-gce, which DOES block PRs from merging, we'll handle that last, after checking the canaries and other jobs. I'm confident it will be fine, but given the timing we're not including that yet.

Reviewers: Excepting the last commit which modifies the tests related to this, every other commit should contain balanced pairs of removing --stage and --extract for each job touched. I checked very carefully, but please double check this.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Aug 8, 2024
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 8, 2024
michelle192837
michelle192837 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@michelle192837 michelle192837 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Unhold at will. Double-checked the commits, and this looks good so far as I can tell.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@BenTheElder BenTheElder mentioned this pull request Aug 9, 2024
Closed
@k8s-ci-robot k8s-ci-robot merged commit 98d6460 into kubernetes:master Aug 9, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@BenTheElder: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-api-machinery-config.yaml using file config/jobs/kubernetes/sig-api-machinery/sig-api-machinery-config.yaml
  • key sig-autoscaling-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/sig-autoscaling-presubmits.yaml
  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key gcp-gpu-presubmits.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gpu/gcp-gpu-presubmits.yaml
  • key sig-network-misc.yaml using file config/jobs/kubernetes/sig-network/sig-network-misc.yaml
  • key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml
  • key 1.27.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
  • key 1.28.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.28.yaml
  • key 1.29.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.29.yaml
  • key 1.30.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.30.yaml
  • key 1.31.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.31.yaml

In response to this:

most of what's left for #18789

TODO: pull-kubernetes-e2e-gce, which DOES block PRs from merging, we'll handle that last, after checking the canaries and other jobs. I'm confident it will be fine, but given the timing we're not including that yet.

Reviewers: Excepting the last commit which modifies the tests related to this, every other commit should contain balanced pairs of removing --stage and --extract for each job touched. I checked very carefully, but please double check this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@BenTheElder BenTheElder deleted the stage-less branch August 9, 2024 00:42
@BenTheElder
Copy link
Member Author

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/126563/pull-kubernetes-e2e-gce-canary/1821708650738094080

@BenTheElder BenTheElder mentioned this pull request Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@bobbypage bobbypage Awaiting requested review from bobbypage

Assignees

@michelle192837 michelle192837

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @michelle192837