drop vsphere-related non-migrated jobs #33241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
michelle192837
approved these changes
Aug 6, 2024
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
BenTheElder
reviewed
Aug 6, 2024
| @@ -484,42 +194,3 @@ periodics: | |||
| testgrid-num-failures-to-alert: "4" | |||
| description: Shows test coverage for CAPV | |||
|
|
|||
| - name: periodic-cluster-api-provider-vsphere-janitor | |||
There was a problem hiding this comment.
we should probably do this in two phases, so the janitor gets a chance to run after the jobs are turned down?
|
/lgtm-cancel |
Merged
ameukam
force-pushed
the
vsphere-prowjobs-cleanup
branch
from
b7b206b to
6c18ee8
Compare
k8s-ci-robot
added
area/testgrid
and removed
lgtm
ameukam
force-pushed
the
vsphere-prowjobs-cleanup
branch
from
6c18ee8 to
d9fe719
Compare
Drop specific prowjobs depending on non-migrated credentials Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
ameukam
force-pushed
the
vsphere-prowjobs-cleanup
branch
from
d9fe719 to
ee6f574
Compare
|
/lgtm Feels bad but we have communicated this pretty heavily and need to keep making progress towards overall migration. |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, BenTheElder, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold cancel /hold cancel this is a git repo, people willing to recover them just need to revert this |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@ameukam: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Don't worry about it. You're putting a lot of work into trying to make this migration as smooth as possible for everyone. If folks / companies are not stepping up in time, it's there problem. It shouldn't be yours :) |
chrischdi
reviewed
Aug 7, 2024
| description: Runs all e2e tests | ||
|
|
||
| - name: pull-cluster-api-provider-vsphere-e2e-vcsim-supervisor-release-1-11 | ||
| cluster: eks-prow-build-cluster |
There was a problem hiding this comment.
This was running on community infra
chrischdi
reviewed
Aug 7, 2024
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop specific prowjobs depending on non-migrated credentials