Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old gcb-docker-gcloud image push job. #33133

Merged

Conversation

michelle192837
Copy link
Contributor

There are still jobs referencing the old image source (gcr.io/k8s-testimages/gcb-docker-gcloud, instead of gcr.io/k8s-staging-test-infra/gcb-docker-gcloud), but since the old location is still available that should be okay. There are no test-infra, documentation, or autobumped references left to the old image, so stop publishing it and let other jobs switch over to the new image source if they need to.

Current uses of the old image: https://cs.k8s.io/?q=gcr.io%2Fk8s-testimages%2Fgcb-docker-gcloud&i=nope&files=&excludeFiles=&repos=

Ref #32432

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and rjsadow July 27, 2024 00:55
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2024
@ameukam
Copy link
Member

ameukam commented Jul 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 29, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michelle192837 michelle192837 force-pushed the deletegcbdockergcloud branch from 0b92eab to 8b78995 Compare July 29, 2024 18:30
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2024
@michelle192837
Copy link
Contributor Author

Okay one moment, that's too many changed lines :/

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
There are still jobs referencing the old image source
(gcr.io/k8s-testimages/gcb-docker-gcloud, instead of
gcr.io/k8s-staging-test-infra/gcb-docker-gcloud), but since the old
location is still available that should be okay. There are no
test-infra, documentation, or autobumped references left to the old
image, so stop publishing it and let other jobs switch over to the new
image source if they need to.
@michelle192837 michelle192837 force-pushed the deletegcbdockergcloud branch from 8b78995 to 8a6587e Compare July 29, 2024 18:34
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 29, 2024
@michelle192837
Copy link
Contributor Author

/hold cancel

Sorry about that, local formatting was too aggressive. Fixed it, but this'll need approval again :(

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2024
@ameukam
Copy link
Member

ameukam commented Jul 29, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@k8s-ci-robot k8s-ci-robot merged commit 01528aa into kubernetes:master Jul 29, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@michelle192837: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key test-infra-trusted.yaml using file config/jobs/kubernetes/test-infra/test-infra-trusted.yaml

In response to this:

There are still jobs referencing the old image source (gcr.io/k8s-testimages/gcb-docker-gcloud, instead of gcr.io/k8s-staging-test-infra/gcb-docker-gcloud), but since the old location is still available that should be okay. There are no test-infra, documentation, or autobumped references left to the old image, so stop publishing it and let other jobs switch over to the new image source if they need to.

Current uses of the old image: https://cs.k8s.io/?q=gcr.io%2Fk8s-testimages%2Fgcb-docker-gcloud&i=nope&files=&excludeFiles=&repos=

Ref #32432

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michelle192837 michelle192837 deleted the deletegcbdockergcloud branch July 29, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants