-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old gcb-docker-gcloud image push job. #33133
Remove old gcb-docker-gcloud image push job. #33133
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
0b92eab
to
8b78995
Compare
Okay one moment, that's too many changed lines :/ /hold |
There are still jobs referencing the old image source (gcr.io/k8s-testimages/gcb-docker-gcloud, instead of gcr.io/k8s-staging-test-infra/gcb-docker-gcloud), but since the old location is still available that should be okay. There are no test-infra, documentation, or autobumped references left to the old image, so stop publishing it and let other jobs switch over to the new image source if they need to.
8b78995
to
8a6587e
Compare
/hold cancel Sorry about that, local formatting was too aggressive. Fixed it, but this'll need approval again :( |
/lgtm |
@michelle192837: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There are still jobs referencing the old image source (gcr.io/k8s-testimages/gcb-docker-gcloud, instead of gcr.io/k8s-staging-test-infra/gcb-docker-gcloud), but since the old location is still available that should be okay. There are no test-infra, documentation, or autobumped references left to the old image, so stop publishing it and let other jobs switch over to the new image source if they need to.
Current uses of the old image: https://cs.k8s.io/?q=gcr.io%2Fk8s-testimages%2Fgcb-docker-gcloud&i=nope&files=&excludeFiles=&repos=
Ref #32432