Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch source for K8s TestGrid production config. #33132

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

michelle192837
Copy link
Contributor

Switches the config source for the K8s slice (the main one) to the config generated by the new job and not the old job.

/hold

Do not merge until we verify that #33130 works.

Ref #32432

Switches the config source for the K8s slice (the main one) to the
config generated by the new job and not the old job.
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot requested review from dims and rjsadow July 26, 2024 23:59
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 26, 2024
@ameukam
Copy link
Member

ameukam commented Jul 29, 2024

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@michelle192837
Copy link
Contributor Author

Canary looks like it's working, but I'm going to let it run for a while longer just to verify it continues to merge the correct config.

@michelle192837
Copy link
Contributor Author

Canary logs for config-merger (in the k8s-testgrid project) indicate it's been picking up the new config just fine. Going to switch this to use the new config as well, then turn down the old config upload job.

@michelle192837
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit eb39446 into kubernetes:master Jul 30, 2024
5 checks passed
@michelle192837 michelle192837 deleted the configmergeprod branch July 30, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants