Adding preset to use Azure resources, moving 2022 master job to azure #32998

ritikaguptams · 2024-07-16T22:03:02Z

No description provided.

k8s-ci-robot · 2024-07-16T22:03:11Z

Hi @ritikaguptams. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jsturtevant · 2024-07-16T22:15:05Z

/cc @nawazkh @jackfrancis

jsturtevant · 2024-07-16T22:15:34Z

fyi @dtzar

config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presets.yaml

jsturtevant · 2024-07-16T22:18:47Z

@ritikaguptams can fix up our testing PR too?

test-infra/config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml

Line 412 in 28b6fd8

- name: pull-e2e-capz-windows-2022-extension-community

jsturtevant · 2024-07-16T22:19:47Z

/ok-to-test

jsturtevant · 2024-07-16T23:43:05Z

config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

  interval: 3h
  decorate: true
  decoration_config:
    timeout: 4h
  labels:
    preset-dind-enabled: "true"
    preset-kind-volume-mounts: "true"
-    preset-azure-cred-wi: "true"
+    preset-azure-community: "true"
    preset-azure-anonymous-pull: "true" # Sets REGISTRY which is needed when building CCM/CNM images


we will need to remove this if we add Registry to the preset.

For windows we don't need it, but we might need to create a different preset for CAPZ which uses USE_LOCAL_KIND_REGISTRY which is in that preset

@jackfrancis registry seems common to jobs but USE_LOCAL_KIND_REGISTRY doesn't. Should we create a new one or just roll USE_LOCAL_KIND_REGISTRY into the new capz preset (it doesn't hurt windows to have that set)

based on this

- name: REGISTRY value: "capzcicommunity.azurecr.io"

yeah it seems like we should include USE_LOCAL_KIND_REGISTRY=false in the preset

Is that what you mean?

jsturtevant · 2024-07-17T16:41:25Z

config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml

@@ -485,7 +473,6 @@ presubmits:
      preset-dind-enabled: "true"
      preset-kind-volume-mounts: "true"
      preset-azure-cred-wi: "true"
-      preset-azure-anonymous-pull: "true" # Sets REGISTRY which is needed when building CCM/CNM images


I don't think we want to be dropping this preset on this job yet.

jsturtevant · 2024-07-17T16:44:00Z

config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

  interval: 3h
  decorate: true
  decoration_config:
    timeout: 4h
  labels:
    preset-dind-enabled: "true"
    preset-kind-volume-mounts: "true"
-    preset-azure-cred-wi: "true"
-    preset-azure-anonymous-pull: "true" # Sets REGISTRY which is needed when building CCM/CNM images
+    preset-azure-community: "true"
    preset-capz-windows-common: "true"
    preset-capz-containerd-1-7-latest: "true"
    preset-windows-private-registry-cred: "true"


This secret won't be in the new k8s-infra-prow-build. We should remove it

Signed-off-by: ritikaguptams <ritikagupta@microsoft.com>

jsturtevant · 2024-07-17T18:29:09Z

config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

    preset-capz-windows-common: "true"
    preset-capz-containerd-1-7-latest: "true"
-    preset-windows-private-registry-cred: "true"


Just a note this will break the test Kubernetes e2e suite.[It] [sig-node] Container Runtime blackbox test when running a container with a new image should be able to pull from private registry with secret [NodeConformance] we are tracking fixing this in kubernetes-sigs/windows-testing#446

jsturtevant · 2024-07-17T18:31:02Z

/lgtm
/approve

nawazkh · 2024-07-17T19:53:13Z

Quite late to the party, thank you.
/lgtm

jackfrancis · 2024-07-17T20:05:43Z

/lgtm
/approve

k8s-ci-robot · 2024-07-17T20:05:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, jsturtevant, ritikaguptams

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes-sigs/cluster-api-provider-azure/OWNERS~~ [jackfrancis]
~~config/jobs/kubernetes-sigs/sig-windows/OWNERS~~ [jsturtevant]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nawazkh · 2024-07-17T20:06:26Z

config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

@@ -259,7 +258,6 @@ periodics:
    path_alias: sigs.k8s.io/cloud-provider-azure
    workdir: false
  spec:
-    serviceAccountName: prowjob-default-sa


What was the reasoning behind dropping this? We dont need this anymore?

I understood we only needed this to "simulate" the community infra service account config, and once we migrated this is the configuration we will expect by default.

Its not needed in the community cluster, the default service account will work

k8s-ci-robot · 2024-07-17T20:19:59Z

@ritikaguptams: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

key cluster-api-provider-azure-presets.yaml using file config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presets.yaml
key release-master-windows-presubmits.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows-presubmits.yaml
key release-master-windows.yaml using file config/jobs/kubernetes-sigs/sig-windows/release-master-windows.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2024

k8s-ci-robot requested review from adelina-t and jsturtevant July 16, 2024 22:03

k8s-ci-robot requested review from jackfrancis and nawazkh July 16, 2024 22:15

jackfrancis reviewed Jul 16, 2024

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presets.yaml Outdated Show resolved Hide resolved

jsturtevant reviewed Jul 16, 2024

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presets.yaml Outdated Show resolved Hide resolved

jsturtevant reviewed Jul 16, 2024

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presets.yaml Outdated Show resolved Hide resolved

jsturtevant reviewed Jul 16, 2024

View reviewed changes

config/jobs/kubernetes-sigs/cluster-api-provider-azure/cluster-api-provider-azure-presets.yaml Outdated Show resolved Hide resolved

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 16, 2024

ritikaguptams force-pushed the move-job-to-azure branch 4 times, most recently from 0c38e9c to bfab502 Compare July 16, 2024 23:40

jsturtevant reviewed Jul 16, 2024

View reviewed changes

ritikaguptams force-pushed the move-job-to-azure branch from bfab502 to 7f5d116 Compare July 16, 2024 23:49

ritikaguptams force-pushed the move-job-to-azure branch 3 times, most recently from a0b969f to 79c8df5 Compare July 17, 2024 16:20

jsturtevant reviewed Jul 17, 2024

View reviewed changes

ritikaguptams force-pushed the move-job-to-azure branch 2 times, most recently from af6d81c to 1bbbd55 Compare July 17, 2024 18:23

Adding preset to use Azure resources, moving 2022 master job to azure

6259f2c

Signed-off-by: ritikaguptams <ritikagupta@microsoft.com>

ritikaguptams force-pushed the move-job-to-azure branch from 1bbbd55 to 6259f2c Compare July 17, 2024 18:26

jsturtevant reviewed Jul 17, 2024

View reviewed changes

k8s-ci-robot assigned jsturtevant Jul 17, 2024

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024

k8s-ci-robot assigned nawazkh Jul 17, 2024

k8s-ci-robot assigned jackfrancis Jul 17, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2024

nawazkh reviewed Jul 17, 2024

View reviewed changes

k8s-ci-robot merged commit 70f90d7 into kubernetes:master Jul 17, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding preset to use Azure resources, moving 2022 master job to azure #32998

Adding preset to use Azure resources, moving 2022 master job to azure #32998

ritikaguptams commented Jul 16, 2024

k8s-ci-robot commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant Jul 16, 2024

jsturtevant Jul 16, 2024

jsturtevant Jul 16, 2024 •

edited

Loading

jackfrancis Jul 17, 2024

ritikaguptams Jul 17, 2024

jsturtevant Jul 17, 2024

jsturtevant Jul 17, 2024

ritikaguptams Jul 17, 2024

jsturtevant Jul 17, 2024

jsturtevant commented Jul 17, 2024

nawazkh commented Jul 17, 2024

jackfrancis commented Jul 17, 2024

k8s-ci-robot commented Jul 17, 2024

nawazkh Jul 17, 2024

jackfrancis Jul 17, 2024

jsturtevant Jul 17, 2024

k8s-ci-robot commented Jul 17, 2024

Adding preset to use Azure resources, moving 2022 master job to azure #32998

Adding preset to use Azure resources, moving 2022 master job to azure #32998

Conversation

ritikaguptams commented Jul 16, 2024

k8s-ci-robot commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

jsturtevant commented Jul 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsturtevant Jul 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsturtevant commented Jul 17, 2024

nawazkh commented Jul 17, 2024

jackfrancis commented Jul 17, 2024

k8s-ci-robot commented Jul 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 17, 2024

jsturtevant Jul 16, 2024 •

edited

Loading