Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build or bump gcsweb and pr-creator images. #32816

Closed
wants to merge 2 commits into from

Conversation

michelle192837
Copy link
Contributor

@michelle192837 michelle192837 commented Jun 21, 2024

These images aren't referenced anywhere, though the code is used independently through other images (registry.k8s.io/gcsweb and gcr.io/k8s-staging-infra-tools/k8s-infra). Remove it from the build/push rules and autobump.

Ref: #32432

These images aren't referenced anywhere, though the code is used
independently through other images (registry.k8s.io/gcsweb and
gcr.io/k8s-staging-infra-tools/k8s-infra). Remove it from the build/push
rules and autobump.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2024
@BenTheElder
Copy link
Member

registry.k8s.io/gcsweb and gcr.io/k8s-staging-infra-tools/k8s-infra

Wait, how are those being pushed? Are these actually unrelated?

@michelle192837
Copy link
Contributor Author

The gcr.io/k8s-prow versions are built/pushed by post-test-infra-push-misc-images. For the other locations:

No idea if registry.k8s.io/gcsweb is being pushed at all, though it looks like it was last uploaded in August 2022. (Maybe just copied over from migration? https://github.com/kubernetes/k8s.io/blob/9f67194fc0b651b5c9486eeecd9ad5762a681f31/k8s.gcr.io/archived/images/DO-NOT-MODIFY-legacy-backfill/images.yaml). I think it just gets deployed using the existing image and isn't auto-pushed:

.

gcr.io/k8s-staging-infra-tools/k8s-infra is being pushed by post-k8sio-push-image-k8s-infra I think.

@michelle192837 michelle192837 deleted the migrate branch July 16, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants