Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the canary kops version of pull-kubernetes-e2e-gce job for k/k #31094

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Create the canary kops version of pull-kubernetes-e2e-gce job for k/k #31094

merged 1 commit into from
Oct 23, 2023

Conversation

upodroid
Copy link
Member

/cc @dims @BenTheElder @aojea @hakman

This PR creates the core gce e2e test we run in k/k presubmits. I also created the serial test as well to test fixes on PRs.

  1. pull-kubernetes-e2e-gce-cos-kubetest2 job is no longer required, kubetest2 gce will be replaced by kubetest2 kops jobs
  2. pull-kubernetes-e2e-kops-aws has no build history. https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/pull-kubernetes-e2e-kops-aws

Part of kubernetes/enhancements#4224

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 22, 2023
@k8s-ci-robot k8s-ci-robot added area/gubernator Issues or PRs related to code in /gubernator area/metrics area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 22, 2023
@upodroid
Copy link
Member Author

/retest

@dims
Copy link
Member

dims commented Oct 22, 2023

/assign @BenTheElder @aojea

aojea
aojea reviewed Oct 23, 2023
View reviewed changes
config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
base_ref: master
path_alias: k8s.io/release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did this mount release? is ok to swap release by kops?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, kops implementes krel to build and stage kube builds

https://github.com/kubernetes/kops/blob/master/tests/e2e/kubetest2-kops/builder/build.go#L67

@aojea
Copy link
Member

aojea commented Oct 23, 2023

Lgtm, has conflicts though

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Oct 23, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 23, 2023
@hakman
Copy link
Member

hakman commented Oct 23, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, hakman, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@upodroid
Copy link
Member Author

/label needs-rebase

@k8s-ci-robot
Copy link
Contributor

@upodroid: The label(s) /label needs-rebase cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label needs-rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid
Copy link
Member Author

Can someone remove the needs-rebase label please? PR has been rebased

@hakman
Copy link
Member

hakman commented Oct 23, 2023

@ameukam Any idea how to remove or re-trigger the needs-rebase check?

@hakman
Copy link
Member

hakman commented Oct 23, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@aojea
Copy link
Member

aojea commented Oct 23, 2023

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@ameukam
Copy link
Member

ameukam commented Oct 23, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@upodroid upodroid closed this Oct 23, 2023
@upodroid upodroid reopened this Oct 23, 2023
@ameukam ameukam removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 030d9b7 into kubernetes:master Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

@upodroid: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key kubernetes-presubmits.yaml using file ``
  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml
  • key 1.25.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
  • key 1.26.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
  • key 1.27.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
  • key 1.28.yaml using file config/jobs/kubernetes/sig-release/release-branch-jobs/1.28.yaml

In response to this:

/cc @dims @BenTheElder @aojea @hakman

This PR creates the core gce e2e test we run in k/k presubmits. I also created the serial test as well to test fixes on PRs.

  1. pull-kubernetes-e2e-gce-cos-kubetest2 job is no longer required, kubetest2 gce will be replaced by kubetest2 kops jobs
  2. pull-kubernetes-e2e-kops-aws has no build history. https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/pull-kubernetes-e2e-kops-aws

Part of kubernetes/enhancements#4224

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@upodroid upodroid mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@hakman hakman hakman left review comments

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dims dims Awaiting requested review from dims

Assignees

@BenTheElder BenTheElder

@ameukam ameukam

@hakman hakman

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/gubernator Issues or PRs related to code in /gubernator area/jobs area/metrics area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@upodroid @dims @aojea @k8s-ci-robot @hakman @ameukam @BenTheElder