-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cluster-api kubekins-e2e version (v20220829-d5650c79bf-1.24 -… #27311
Conversation
Welcome @oscr! |
Hi @oscr. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -275,7 +275,7 @@ presubmits: | |||
spec: | |||
serviceAccountName: prowjob-default-sa | |||
containers: | |||
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220829-d5650c79bf-1.24 | |||
- image: gcr.io/k8s-staging-test-infra/kubekins-e2e:v20220829-d5650c79bf-1.25 | |||
args: | |||
- runner.sh | |||
- "./scripts/ci-e2e.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one more image below (pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oscr Can you please also open a second PR to do the same in cluster-api-periodics-main-upgrades.yaml and cluster-api-periodics-main.yaml
(intentionally a separate PR so I can merge the second one after I know the presubmit jobs are working after the first one)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbueringer Great catch! I don't know how I missed it, and you where able to catch it. This pr is updated. I will fix a separate as requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thx! :)
/ok-to-test |
@oscr Btw you can open an org membership PR for the kubernetes org (as you're already a member of kubernetes-sigs) xref: https://github.com/kubernetes/community/blob/master/community-membership.md#kubernetes-ecosystem |
…> v20220829-d5650c79bf-1.25)
62b8f1c
to
f551fef
Compare
Thx! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oscr, sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@oscr: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Upgrading as part of kubernetes-sigs/cluster-api#6661
/assign @sbueringer