Kops - remove tests of unsupported distros #24542
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added
area/testgrid
and removed
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -47,8 +47,6 @@ dashboards: | |||
| - name: kops-gce | |||
| - name: kops-grid | |||
| - name: kops-distro-amzn2 | |||
| - name: kops-distro-centos7 | |||
| - name: kops-distro-centos8 | |||
| - name: kops-distro-deb9 | |||
There was a problem hiding this comment.
Probably this should go too and same for u1804 one:
| - name: kops-distro-deb9 |
There was a problem hiding this comment.
deb9 is still used in our grid jobs for kops <= 1.22, thats why the unit test didnt complain about it and why i kept it in distro_images
| @@ -136,8 +136,6 @@ def latest_aws_image(owner, name): | |||
|
|
|||
| distro_images = { | |||
| 'amzn2': latest_aws_image('137112412989', 'amzn2-ami-kernel-5.10-hvm-*-x86_64-gp2'), | |||
| 'centos7': latest_aws_image('125523088429', 'CentOS 7.*x86_64'), | |||
| 'centos8': latest_aws_image('125523088429', 'CentOS 8.*x86_64'), | |||
There was a problem hiding this comment.
SSH users should be removed too. Also, not sure where u1804 is still used.
There was a problem hiding this comment.
good call. 1804 is also still used in the grid for older kops versions.
There was a problem hiding this comment.
ok, but not sure how valuable it is.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@rifelpet: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ref: kubernetes/kops#12882
/cc @hakman