-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sig-node: migrate away from GCP project : cri-containerd-node-e2e #24462
sig-node: migrate away from GCP project : cri-containerd-node-e2e #24462
Conversation
Hi @rayandas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc: @ameukam |
/ok-to-test |
@rayandas I recommend to not use terms in the PR description that will auto-close it. :) |
@ameukam ah! right. |
/lgtm |
Any objections to waiting until after the release is cut to merge this? I don't really want to make job changes while we're in freeze. |
/hold |
6f31447
to
5a527eb
Compare
@ameukam added |
ad5d179
to
f4531d7
Compare
f69f34e
to
d90dc8a
Compare
d90dc8a
to
34c3a09
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
this looks fine, I'll keep an eye to see if any failures start
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, rayandas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@rayandas: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR migrates cri-containerd-node-e2e