Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: README update to trigger image builds #23579

Merged
merged 1 commit into from
Sep 13, 2021
Merged

images: README update to trigger image builds #23579

merged 1 commit into from
Sep 13, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Sep 13, 2021 •
edited
Loading

Related:

Here's another README-only update to trigger image builds now that the jobs have been updated via autobump to use the latest image-builder

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/images sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 13, 2021

/hold
For #23580 to merge first

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 13, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Sep 13, 2021

/cc @dims @ameukam

@ameukam
Copy link
Member

ameukam commented Sep 13, 2021

/lgtm

dims
dims approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@dims dims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp spiffxp mentioned this pull request Sep 13, 2021
Open
77 tasks
@k8s-ci-robot k8s-ci-robot merged commit fc7c4e8 into kubernetes:master Sep 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 13, 2021
@spiffxp spiffxp deleted the trigger-image-builds-again branch September 13, 2021 20:42
@spiffxp spiffxp mentioned this pull request Sep 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@e-blackwelder e-blackwelder Awaiting requested review from e-blackwelder

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@dims dims

@ameukam ameukam

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/images cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@spiffxp @ameukam @k8s-ci-robot @dims