Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish TODO in upgrade test config #20395

Merged
merged 1 commit into from
Feb 23, 2021
Merged

finish TODO in upgrade test config #20395

merged 1 commit into from
Feb 23, 2021

Conversation

zshihang
Copy link
Contributor

@zshihang zshihang commented Jan 7, 2021

fix: #19575

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Jan 7, 2021
@k8s-ci-robot k8s-ci-robot added area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 7, 2021
liggitt
liggitt reviewed Jan 7, 2021
View reviewed changes
config/jobs/kubernetes/sig-auth/serviceaccount-admission-controller-migration-config.yaml Outdated
Comment on lines 25 to 26
- --extract=ci/stable
- --extract=ci/stable-1.19
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fuzzy about what these represent... is ci/stable the latest 1.20.x release or the latest commit on release-1.20 branch? Same question for ci/stable-1.19.

If we want to test upgrade from the latest release to current dev branch, should this be ci/latest and ci/stable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci/latest ci/stable
v1.21.0-alpha.0 v1.20.1
ci/latest-1.20 ci/stable-1.20
v1.20.2-rc.0 v1.20.1

yea, ci/stable is the latest 1.20.x while ci/latest has the largest tag number. e.g. v1.21.0-alpha.0

with bound beta, latest or stable will eventually have bound enabled by default and this upgrade will not have much value.

my current plan is fix the initial version to versions with bound alpha (e.g. ci/stable-1.19) and upgrade to ci/stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless we want this job to tell us something broke after we cut a release, I'm pretty sure the version we're upgrading to should be using latest instead of stable

given we also didn't enable BoundServiceAccountTokenVolume by default in 1.20, I think this should probably just test from ci/latest-1.20 to ci/latest for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 11, 2021
@spiffxp
Copy link
Member

spiffxp commented Jan 19, 2021

/test pull-test-infra-integration
#20498 (comment)

@liggitt
Copy link
Member

liggitt commented Jan 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@mikedanese
Copy link
Member

/lgtm

@mikedanese
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, zshihang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit c45689b into kubernetes:master Feb 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 23, 2021
@k8s-ci-robot
Copy link
Contributor

@zshihang: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key serviceaccount-admission-controller-migration-config.yaml using file config/jobs/kubernetes/sig-auth/serviceaccount-admission-controller-migration-config.yaml

In response to this:

fix: #19575

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@liggitt liggitt

@mikedanese mikedanese

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

TODOs for sig-auth-serviceaccount-admission-controller-migration upgrade test
5 participants
@zshihang @spiffxp @liggitt @mikedanese @k8s-ci-robot