Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test job for service-api tests #20281

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add test job for service-api tests #20281

merged 1 commit into from
Jan 11, 2021

Conversation

cmluciano
Copy link

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

xref: kubernetes-sigs/gateway-api#507

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Dec 17, 2020
@k8s-ci-robot k8s-ci-robot requested review from aojea and dims December 17, 2020 19:45
@cmluciano
Copy link
Author

cc @robscott

@cmluciano
Copy link
Author

/hold

wait until kubernetes-sigs/gateway-api#508 merges

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 17, 2020
@cmluciano cmluciano mentioned this pull request Dec 17, 2020
Closed
2 tasks
Add test job for service-api tests
7d310a8 
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@cmluciano
Copy link
Author

The dependent PR is now merged

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 29, 2020
aojea
aojea reviewed Dec 29, 2020
View reviewed changes
config/jobs/kubernetes-sigs/service-apis/service-apis-config.yaml
decorate: true
path_alias: sigs.k8s.io/service-apis
always_run: true
skip_report: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should you start with optional: true to avoid that if something fails it blocks other PR to merge?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link where the optional field is detailed ? I can't figure out how some of these flags work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#requiring-jobs-for-auto-merge-through-tide
it means that it doesn't block the merge if it fails, however, if you are sure that the tests will pass it is not required

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently I am only adding unit tests which should pass at all times but I can foresee some experimental features that might be listed as optional.

@hbagdi @robscott Do you have any opinions on whether this new job should be marked optional now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any opinions on whether this new job should be marked optional now?

I think we should start with optional: false since that's the whole purpose of adding these tests. We can keep the tests in a temporary dev branch if they happen to be temporarily breaking.

@aojea
Copy link
Member

aojea commented Jan 4, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@dims
Copy link
Member

dims commented Jan 4, 2021

looks like this is not ready yet. can someone please add a WIP or hold?

@aojea
Copy link
Member

aojea commented Jan 5, 2021

looks like this is not ready yet. can someone please add a WIP or hold?

is it not? I ran it and it didn't fail

service-apis]$ make test
go test ./...
go: downloading golang.org/x/net v0.0.0-20200904194848-62affa334b73
go: downloading k8s.io/kube-openapi v0.0.0-20200831175022-64514a1d5d59
?       sigs.k8s.io/service-apis/apis/v1alpha1  [no test files]
?       sigs.k8s.io/service-apis/pkg/client/clientset/versioned [no test files]
?       sigs.k8s.io/service-apis/pkg/client/clientset/versioned/fake    [no test files]
?       sigs.k8s.io/service-apis/pkg/client/clientset/versioned/scheme  [no test files]
?       sigs.k8s.io/service-apis/pkg/client/clientset/versioned/typed/apis/v1alpha1     [no test files]
?       sigs.k8s.io/service-apis/pkg/client/clientset/versioned/typed/apis/v1alpha1/fake        [no test files]
?       sigs.k8s.io/service-apis/pkg/client/informers/externalversions  [no test files]
?       sigs.k8s.io/service-apis/pkg/client/informers/externalversions/apis     [no test files]
?       sigs.k8s.io/service-apis/pkg/client/informers/externalversions/apis/v1alpha1    [no test files]
?       sigs.k8s.io/service-apis/pkg/client/informers/externalversions/internalinterfaces       [no test files]
?       sigs.k8s.io/service-apis/pkg/client/listers/apis/v1alpha1       [no test files]

no tests though

@cmluciano
Copy link
Author

This is not a WIP. Tests are added here

@aojea
Copy link
Member

aojea commented Jan 5, 2021

/assign @bowei @robscott
for approval

@bowei
Copy link
Member

bowei commented Jan 11, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, cmluciano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 5d64d2b into kubernetes:master Jan 11, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 11, 2021
@k8s-ci-robot
Copy link
Contributor

@cmluciano: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key service-apis-config.yaml using file config/jobs/kubernetes-sigs/service-apis/service-apis-config.yaml

In response to this:

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

xref: kubernetes-sigs/gateway-api#507

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MushuEE MushuEE MushuEE left review comments

@aojea aojea aojea left review comments

@hbagdi hbagdi hbagdi left review comments

@dims dims Awaiting requested review from dims

Assignees

@robscott robscott

@bowei bowei

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
8 participants
@cmluciano @aojea @dims @bowei @k8s-ci-robot @hbagdi @MushuEE @robscott