Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud-provider-openstack: set ignore_review_state to true #19824

Merged
merged 1 commit into from
Nov 4, 2020
Merged

cloud-provider-openstack: set ignore_review_state to true #19824

merged 1 commit into from
Nov 4, 2020

Conversation

lingxiankong
Copy link
Contributor

Sets ignore_review_state to true for kubernetes/cloud-provider-openstack to avoid the auto approval for the PRs submitted by the person with 'approve' permission.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config labels Nov 3, 2020
@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Nov 3, 2020
@lingxiankong
Copy link
Contributor Author

/cc @dims @ramineni @jichenjc

@@ -99,6 +99,10 @@ approve:
- helm/charts
require_self_approval: false
lgtm_acts_as_approve: true
- repos:
- kubernetes/cloud-provider-openstack
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add this line after 99 before 100 i think. since that section has the flags you need ( require_self_approval - false and ignore_review_state - true)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn't include ignore_review_state, does it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops. you are right

@jichenjc
Copy link
Contributor

jichenjc commented Nov 4, 2020

the purpose of this PR lgtm , thanks for this @lingxiankong

@dims
Copy link
Member

dims commented Nov 4, 2020

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit e42b074 into kubernetes:master Nov 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 4, 2020
@k8s-ci-robot
Copy link
Contributor

@lingxiankong: Updated the plugins configmap in namespace default at cluster test-infra-trusted using the following files:

  • key plugins.yaml using file config/prow/plugins.yaml

In response to this:

Sets ignore_review_state to true for kubernetes/cloud-provider-openstack to avoid the auto approval for the PRs submitted by the person with 'approve' permission.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants