-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-provider-openstack: set ignore_review_state to true #19824
Conversation
@@ -99,6 +99,10 @@ approve: | |||
- helm/charts | |||
require_self_approval: false | |||
lgtm_acts_as_approve: true | |||
- repos: | |||
- kubernetes/cloud-provider-openstack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can add this line after 99 before 100 i think. since that section has the flags you need ( require_self_approval - false and ignore_review_state - true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it doesn't include ignore_review_state
, does it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops. you are right
the purpose of this PR lgtm , thanks for this @lingxiankong |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, lingxiankong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lingxiankong: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sets ignore_review_state to true for kubernetes/cloud-provider-openstack to avoid the auto approval for the PRs submitted by the person with 'approve' permission.