-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster API: set ignore_review_state to true #19623
Cluster API: set ignore_review_state to true #19623
Conversation
/lgtm |
/approve |
/lgtm |
lgtm, thanks for figuring this out! |
/assign @dims |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, dims, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@CecileRobertMichon: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sets
ignore_review_state
to true for Cluster API repos and thus restores behavior before #19579 merged which caused the default behavior to take the GitHub review state into account for "approve". This avoids approvers accidentally applying the/approve
label on PRs when reviewing.kubernetes-sigs/cluster-api#3616 (comment)
/assign @vincepri @fabriziopandini @devigned @randomvariable @detiber