Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests after changing default image to Ubuntu 20.04 #17864

Merged
merged 1 commit into from
Jun 6, 2020
Merged

Update tests after changing default image to Ubuntu 20.04 #17864

merged 1 commit into from
Jun 6, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Jun 6, 2020

Changes:

  • defaults KUBE_SSH_USER to ubuntu
  • sets KUBE_SSH_USER to admin for Kubernetes 1.16 and 1.17
  • autodetects --kops-ssh-user in Kops
  • updates default image for Ubuntu 20.04 to latest
  • adds daily test for Ubuntu 20.04 in grid

/cc @justinsb @rifelpet

@k8s-ci-robot k8s-ci-robot requested review from justinsb and rifelpet June 6, 2020 04:55
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jun 6, 2020
@hakman hakman force-pushed the kops-1.18-ubuntu branch from cd2d0b2 to 9e43c40 Compare June 6, 2020 05:15
This was referenced Jun 6, 2020
Merged
Merged
Merged
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2020
@mikesplain
Copy link
Contributor

Thanks @hakman!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, mikesplain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit 36d2a54 into kubernetes:master Jun 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Jun 6, 2020
@k8s-ci-robot
Copy link
Contributor

@hakman: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kops-periodics-distros.yaml using file config/jobs/kubernetes/kops/kops-periodics-distros.yaml
  • key kops-periodics-grid.yaml using file config/jobs/kubernetes/kops/kops-periodics-grid.yaml
  • key kops-periodics-misc.yaml using file config/jobs/kubernetes/kops/kops-periodics-misc.yaml
  • key kops-periodics-network-plugins.yaml using file config/jobs/kubernetes/kops/kops-periodics-network-plugins.yaml
  • key kops-periodics-versions.yaml using file config/jobs/kubernetes/kops/kops-periodics-versions.yaml
  • key kops-presets.yaml using file config/jobs/kubernetes/kops/kops-presets.yaml
  • key kops-presubmits.yaml using file config/jobs/kubernetes/kops/kops-presubmits.yaml

In response to this:

Changes:

  • defaults KUBE_SSH_USER to ubuntu
  • sets KUBE_SSH_USER to admin for Kubernetes 1.16 and 1.17
  • autodetects --kops-ssh-user in Kops
  • updates default image for Ubuntu 20.04 to latest
  • adds daily test for Ubuntu 20.04 in grid

/cc @justinsb @rifelpet

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 6, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@rifelpet rifelpet Awaiting requested review from rifelpet

Assignees

@olemarkus olemarkus

@mikesplain mikesplain

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @olemarkus @mikesplain @k8s-ci-robot