Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubetest2: implement "EKS" deployer, deprecate eks kubetest1 #16890

Merged
merged 1 commit into from
Mar 26, 2020
Merged

kubetest2: implement "EKS" deployer, deprecate eks kubetest1 #16890

merged 1 commit into from
Mar 26, 2020

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Mar 21, 2020

ref. #11380

@BenTheElder Is there any example config to use kubetest2? kubetest1 for EKS has not been maintained... We'd like to fix it with kubetest2.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 21, 2020
@k8s-ci-robot k8s-ci-robot added area/kubetest sig/testing Categorizes an issue or PR as relevant to SIG Testing. area/config Issues or PRs related to code in /config area/provider/aws Issues or PRs related to aws provider area/testgrid sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 21, 2020
@gyuho gyuho changed the title kubetest2: implement "EKS" deployer, deprecate eks kubetest1 [WIP] kubetest2: implement "EKS" deployer, deprecate eks kubetest1 Mar 21, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2020
@BenTheElder
Copy link
Member

/assign @amwat

@gyuho
Copy link
Member Author

gyuho commented Mar 24, 2020

@amwat @BenTheElder Any updates? The kubetest1 EKS jobs have been broken... I would like to fix ASAP. Please let me know!

@cofyc cofyc mentioned this pull request Mar 24, 2020
Closed
@BenTheElder
Copy link
Member

I am handing off initial reviews of kubetest2 @amwat to loadbalance my PR review assignment overflow. Amit is very familiar with the kubetest2 internals and reviewed a lot of the existing code.

feel free to ping me for an approve when this is reviewed.

@BenTheElder BenTheElder requested a review from amwat March 24, 2020 02:41
amwat
amwat reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
for the kubetest2 parts

kubetest2/kubetest2-eks/main.go
package main

import (
"github.com/aws/aws-k8s-tester/eks"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: looks like this is actually the deployer implementation.
this might get confusing later since "tester" has a different meaning in the kubetest2 sense.

might want to rename this later (just something to keep at the back of our minds) .

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 25, 2020
@gyuho gyuho changed the title [WIP] kubetest2: implement "EKS" deployer, deprecate eks kubetest1 kubetest2: implement "EKS" deployer, deprecate eks kubetest1 Mar 25, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2020
@gyuho
Copy link
Member Author

gyuho commented Mar 25, 2020

@amwat PTAL.

I would like to get this kubetest2 change merged in, and write the new config for it in the separate PR. Do we have any example to trigger tests in kubetest2?

@gyuho
Copy link
Member Author

gyuho commented Mar 25, 2020

/test pull-test-infra-bazel

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 25, 2020 •
edited
Loading

@gyuho: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-test-infra-prow-checkconfig fc44888 link /test pull-test-infra-prow-checkconfig

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@amwat
Copy link
Contributor

amwat commented Mar 25, 2020

Do we have any example to trigger tests in kubetest2?

we don't have any prowjobs on this yet and currently kind is the only deployer that is working and exec is the only tester that is working.

go install ./kubetest2 
go install ./kubetest2/kubetest2-kind

and a typical run looks like this:

kubetest2 kind --up --down --test=exec -- ./mytest.sh

we are working on standardizing around this soon.

amwat
amwat reviewed Mar 25, 2020
View reviewed changes
kubetest/eks.go
}

// newEKS creates a new EKS deployer.
func newEKS(timeout time.Duration, verbose bool) (ekstester.Deployer, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like kubetest main uses this

test-infra/kubetest/main.go

Lines 243 to 244 in e86e60c

case "eks":
return newEKS(timeout, verbose)

maybe also leave deletion of kubetest1 eks as a follow PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, just fixed it. We are ok to remove kubetest1 now, since it's broken.

@gyuho
Copy link
Member Author

gyuho commented Mar 25, 2020

kubetest2 kind --up --down --test=exec -- ./mytest.sh
we are working on standardizing around this soon.

Happy to contribute. I will research more to see if we can support other tooling.

@gyuho
Copy link
Member Author

gyuho commented Mar 25, 2020

@amwat PTAL.

gyuho added a commit to aws/aws-k8s-tester that referenced this pull request Mar 25, 2020
@gyuho
ekstester: remove
a6cc130 
ref. kubernetes/test-infra#16890

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@gyuho
kubetest2: implement "EKS" deployer, deprecate eks kubetest1
d12ff4e 
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
amwat
amwat reviewed Mar 25, 2020
View reviewed changes
Copy link
Contributor

@amwat amwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2020
@gyuho
Copy link
Member Author

gyuho commented Mar 26, 2020

@BenTheElder Kindly ping :)

@BenTheElder
Copy link
Member

/approve
thanks all!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, gyuho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit d70439e into kubernetes:master Mar 26, 2020
@gyuho gyuho deleted the kubetest2-eks branch March 26, 2020 22:42
@gyuho gyuho mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amwat amwat amwat left review comments

Assignees

@amwat amwat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/kubetest area/provider/aws Issues or PRs related to aws provider area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @BenTheElder @k8s-ci-robot @amwat