-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test for kubeflow 0.5 #11954
Update test for kubeflow 0.5 #11954
Conversation
Hi @lluunn. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -2336,6 +2336,8 @@ test_groups: | |||
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-e2e-gke-gci-new-gci-master-upgrade-cluster-new-parallel | |||
- name: ci-kubernetes-multicluster-ingress-test | |||
gcs_prefix: kubernetes-jenkins/logs/ci-kubernetes-multicluster-ingress-test | |||
- name: kubeflow-periodic-0-5-branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may also need to update https://github.com/kubernetes/test-infra/blob/master/testgrid/config.yaml#L5641
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! updated
/lgtm |
@richardsliu: changing LGTM is restricted to assignees, and only kubernetes/test-infra repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unassign |
Thanks @BenTheElder , didn't notice we have the OWNERS file. |
/lgtm |
LGTM label has been added. Git tree hash: a4859011700d023297ae1a4d39ff5a8a46f92d95
|
/assign @michelle192837 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi, lluunn, michelle192837 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@lluunn: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
for kubeflow/kubeflow#2716
cc @richardsliu