Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR stuck in merge pool when one test is still failing #15220

Closed
Bobgy opened this issue Nov 11, 2019 · 3 comments
Closed

PR stuck in merge pool when one test is still failing #15220

Bobgy opened this issue Nov 11, 2019 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Bobgy
Copy link
Contributor

Bobgy commented Nov 11, 2019

What happened:
kubeflow/pipelines#2559 has tide status: in merge pool.
Even though one test is failing.
However, prow bot doesn't merge it, so it's stuck in this status and also blocks future PRs from being merged automatically.

What you expected to happen:
Prow bot should move it out of merge pool.

How to reproduce it (as minimally and precisely as possible):
I don't know, take a look at the PR's history. I think something subtle happened.

Please provide links to example occurrences, if any:

Anything else we need to know?:

@Bobgy Bobgy added the kind/bug Categorizes issue or PR as related to a bug. label Nov 11, 2019
@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 12, 2019

After more commits added to the PR, it is pulled out of merge pool correctly.

@Bobgy
Copy link
Contributor Author

Bobgy commented Nov 12, 2019

This seems to be caused by kubeflow/pipelines#1653.
Solve the problem there
/close

@k8s-ci-robot
Copy link
Contributor

@Bobgy: Closing this issue.

In response to this:

This seems to be caused by kubeflow/pipelines#1653.
Solve the problem there
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants