Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove knative/build options/dependencies from prow #14217

Closed
vdemeester opened this issue Sep 6, 2019 · 4 comments
Closed

Remove knative/build options/dependencies from prow #14217

vdemeester opened this issue Sep 6, 2019 · 4 comments
Assignees
Labels
area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow Issues or PRs related to prow kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@vdemeester
Copy link

What should be cleaned up or changed:

Knative build (knative/build) is now deprecated and read-only, hence not maintained anymore — see knative/build#614 for the history.

Prow shouldn't rely on it as it is not maintained anymore, and should focus on tektoncd/pipeline instead (which is kinda already the case as it is also supported in Prow).

Additionnaly, this would remove github.com/knative/* dependencies as knative/build didn't switch to those before being deprecated.

/cc @bobcatfish @imjasonh

Provide any links for context:

See #14216 (comment)

@vdemeester vdemeester added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 6, 2019
@stevekuznetsov
Copy link
Contributor

Alternatively, can we copy paste the client types from these third-party dependencies into third_party/ to ensure that prow does not import the whole world and ameliorate all of our current issues re: imports?

/cc @cjwagner @cblecker @fejta

@BenTheElder BenTheElder added area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow Issues or PRs related to prow labels Sep 17, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 16, 2019
@vdemeester
Copy link
Author

#15022 is merged, this can be closed
/close

@k8s-ci-robot
Copy link
Contributor

@vdemeester: Closing this issue.

In response to this:

#15022 is merged, this can be closed
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow Issues or PRs related to prow kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

6 participants