Make unit and integration go-compatibility presubmits required

kubernetes · May 23, 2023 · 7796f72 · 7796f72
1 parent c480e22
commit 7796f72
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 12 deletions.
diff --git a/config/jobs/kubernetes/sig-release/release-branch-jobs/1.24.yaml b/config/jobs/kubernetes/sig-release/release-branch-jobs/1.24.yaml
@@ -1412,7 +1412,6 @@ presubmits:
       preset-dind-enabled: "true"
       preset-service-account: "true"
     name: pull-kubernetes-integration-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:
@@ -1590,7 +1589,6 @@ presubmits:
     labels:
       preset-service-account: "true"
     name: pull-kubernetes-unit-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:

diff --git a/config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml b/config/jobs/kubernetes/sig-release/release-branch-jobs/1.25.yaml
@@ -1424,7 +1424,6 @@ presubmits:
       preset-dind-enabled: "true"
       preset-service-account: "true"
     name: pull-kubernetes-integration-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:
@@ -1602,7 +1601,6 @@ presubmits:
     labels:
       preset-service-account: "true"
     name: pull-kubernetes-unit-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:

diff --git a/config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml b/config/jobs/kubernetes/sig-release/release-branch-jobs/1.26.yaml
@@ -1453,7 +1453,6 @@ presubmits:
       preset-dind-enabled: "true"
       preset-service-account: "true"
     name: pull-kubernetes-integration-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:
@@ -1629,7 +1628,6 @@ presubmits:
     labels:
       preset-service-account: "true"
     name: pull-kubernetes-unit-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:

diff --git a/config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml b/config/jobs/kubernetes/sig-release/release-branch-jobs/1.27.yaml
@@ -1404,7 +1404,6 @@ presubmits:
       preset-dind-enabled: "true"
       preset-service-account: "true"
     name: pull-kubernetes-integration-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:
@@ -1583,7 +1582,6 @@ presubmits:
     labels:
       preset-service-account: "true"
     name: pull-kubernetes-unit-go-compatibility
-    optional: true
     path_alias: k8s.io/kubernetes
     spec:
       containers:

diff --git a/config/jobs/kubernetes/sig-testing/integration.yaml b/config/jobs/kubernetes/sig-testing/integration.yaml
@@ -36,14 +36,13 @@ presubmits:
   - name: pull-kubernetes-integration-go-compatibility
     cluster: k8s-infra-prow-build
     always_run: true
-    optional: true
     decorate: true
     skip_branches:
     - .* # per-release job
     annotations:
       fork-per-release: "true"
       fork-per-release-replacements: "GO_VERSION= -> GO_VERSION={{.GoVersion}}"
-      testgrid-dashboards: sig-testing-canaries
+      testgrid-dashboards: presubmits-kubernetes-blocking
       description: run with GO_VERSION set to the original go version used for this branch
     path_alias: k8s.io/kubernetes
     labels:

diff --git a/config/jobs/kubernetes/sig-testing/make-test.yaml b/config/jobs/kubernetes/sig-testing/make-test.yaml
@@ -39,15 +39,14 @@ presubmits:
     annotations:
       fork-per-release: "true"
       fork-per-release-replacements: "GO_VERSION= -> GO_VERSION={{.GoVersion}}"
-      testgrid-dashboards: sig-testing-canaries
+      testgrid-dashboards: presubmits-kubernetes-blocking
       description: run with GO_VERSION set to the original go version used for this branch
     decorate: true
     cluster: k8s-infra-prow-build
     skip_branches:
     - .* # per-release job
     labels:
       preset-service-account: "true"
-    optional: true
     always_run: true
     path_alias: k8s.io/kubernetes
     spec:

diff --git a/config/testgrids/kubernetes/presubmits/config.yaml b/config/testgrids/kubernetes/presubmits/config.yaml
@@ -37,6 +37,9 @@ dashboards:
   - name: pull-kubernetes-integration
     test_group_name: pull-kubernetes-integration
     base_options: width=10
+  - name: pull-kubernetes-integration-go-compatibility
+    test_group_name: pull-kubernetes-integration-go-compatibility
+    base_options: width=10
   - name: pull-kubernetes-verify
     test_group_name: pull-kubernetes-verify
     base_options: width=10