Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first-round drafts for k8s 1.12 Release Team #168

Merged
merged 18 commits into from
Jun 15, 2018

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Jun 5, 2018

ref: #167

/assign @tpepper @jberkus @jdumars
/cc @tpepper @AishSundar @kacole2

Signed-off-by: Stephen Augustus foo@agst.us

Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot
Copy link
Contributor

@justaugustus: GitHub didn't allow me to request PR reviews from the following users: kacole2.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @jberkus @jdumars
/cc @tpepper @AishSundar @kacole2

Signed-off-by: Stephen Augustus foo@agst.us

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from AishSundar June 5, 2018 22:35
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2018
Signed-off-by: Stephen Augustus <foo@agst.us>
@justaugustus
Copy link
Member Author

/sig release

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 6, 2018
Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
* Docs Lead: Zach Arnold
* Docs Shadow: Samuel Tauil

Signed-off-by: Stephen Augustus <foo@agst.us>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2018
Signed-off-by: Stephen Augustus <foo@agst.us>
| Release Notes |||
| Communications |||
| Communications | Kaitlyn Barnard ([@kbarnard10](https://github.com/kbarnard10)) ||
| Patch Release Manager |||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to be the Patch Release Manager

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, @feiskyer. Thanks for volunteering!

@jberkus
Copy link
Contributor

jberkus commented Jun 7, 2018

Can we add "PR Triage" as a position? I nominate @dims for lead.

I'll create a PR for the position.

@dims
Copy link
Member

dims commented Jun 7, 2018

@jberkus +1 to "PR Triage" as a new position. Let's leave it empty for now, let's see if we get anyone else who wants to help with it first.

Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
@calebamiles
Copy link
Contributor

If we're proposing adding more positions, @jberkus, I would suggest also adding a role focused on upgrade/downgrade testing

Signed-off-by: Stephen Augustus <foo@agst.us>
@justaugustus
Copy link
Member Author

/assign @tpepper

@justaugustus
Copy link
Member Author

Pending filling all lead roles...
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2018
@tpepper
Copy link
Member

tpepper commented Jun 8, 2018

Regarding adding PR Triage: depending on how the future happens there's shifting overlaps between feature/PM oversight, issue triage, PR triage, and CI signal. MASSIVE CI signal attention seems to have lead to notably less issues in 1.11. The removal of requiring issues for PRs seems to have lead to less issues in 1.10 and 1.11 as well. But both of these reducing issue counts and issue connection to the milestone means less artifacts visible to the release team. In this context, while it incurs overhead on staffing, I like having these roles as separate. More pairs of eyeballs across this set makes for a more diverse risk management stance for the overall release.

Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
| Communications |||
| Patch Release Manager |||
| Lead | Tim Pepper ([@tpepper](https://github.com/tpepper)) | Aishwarya Sundar ([@AishSundar](https://github.com/AishSundar)) |
| Features | Stephen Augustus ([@justaugustus](https://github.com/justaugustus)) | Kendrick Coleman ([@kacole2](https://github.com/kacole2)), Robert Sandoval ([@robertsandoval](https://github.com/robertsandoval)), Rajendar Talatam ([@rajendar38](https://github.com/rajendar38)) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fine that we'll have multiple shadows for this role?

Not against it, just would like to clarify.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we're trying to overstaff this release cycle as:

  1. We're doing it much earlier than usual, so if prior commitments prevent people from participating, we will still be reasonably staffed.
  2. More eyes on every role should provide better coverage and allow us to iterate faster on improvements.

| Lead | Tim Pepper ([@tpepper](https://github.com/tpepper)) | Aishwarya Sundar ([@AishSundar](https://github.com/AishSundar)) |
| Features | Stephen Augustus ([@justaugustus](https://github.com/justaugustus)) | Kendrick Coleman ([@kacole2](https://github.com/kacole2)), Robert Sandoval ([@robertsandoval](https://github.com/robertsandoval)), Rajendar Talatam ([@rajendar38](https://github.com/rajendar38)) |
| CI Signal || Christian Hernandez ([@christianh814](https://github.com/christianh814)) |
| Test Infra | Cole Wagner ([@cjwagner](https://github.com/cjwagner)) | Amit Watve ([@amwat](https://github.com/amwat)), Paul Renato ([@prwitt](https://github.com/prwitt)) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same question (Is it fine that we'll have multiple shadows for this role?)

Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
jimangel and others added 3 commits June 14, 2018 23:52
Signed-off-by: Stephen Augustus <foo@agst.us>
Signed-off-by: Stephen Augustus <foo@agst.us>
@justaugustus
Copy link
Member Author

@tpepper @jberkus -- we've got most of the roles staffed with multiple shadows at this point.
Can y'all drop an /lgtm on this?

@tpepper
Copy link
Member

tpepper commented Jun 15, 2018

I'm trying to track down a branch manager, but this may as well merge in the meantime for visibility.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2018
@tpepper
Copy link
Member

tpepper commented Jun 15, 2018

Also for the record, we discussed back and forth and are going to continue with "Bug Triage" which will cover both GitHub issue and PR type artifacts.

@tpepper
Copy link
Member

tpepper commented Jun 15, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 15, 2018
@tpepper
Copy link
Member

tpepper commented Jun 15, 2018

/assign @jberkus

@jberkus
Copy link
Contributor

jberkus commented Jun 15, 2018

Let's see if I have approve powers:

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, justaugustus, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 15, 2018
@k8s-ci-robot k8s-ci-robot merged commit 1b19732 into kubernetes:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants