Skip to content

Commit

Permalink
Merge pull request #614 from idealhack/fix-gcloud-builds
Browse files Browse the repository at this point in the history
Replace `gcloud container builds` with `gcloud builds`
  • Loading branch information
k8s-ci-robot authored Aug 24, 2018
2 parents 8bc6167 + 48c370a commit d63e56e
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion build/Dockerfile.k8s-cloud-builder
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# To rebuild and publish this container run:
# gcloud container builds submit --config update_build_container.yaml .
# gcloud builds submit --config update_build_container.yaml .

FROM ubuntu

Expand Down
2 changes: 1 addition & 1 deletion build/build-k8s-cloud-builder-container
Original file line number Diff line number Diff line change
@@ -1 +1 @@
gcloud container builds submit --config k8s-container.yaml .
gcloud builds submit --config k8s-container.yaml .
2 changes: 1 addition & 1 deletion build/godep-builder/cloudbuild.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# In this directory, run the following command to build this builder.
# $ gcloud container builds submit . --config=cloudbuild.yaml
# $ gcloud builds submit . --config=cloudbuild.yaml

steps:
- name: 'gcr.io/cloud-builders/docker'
Expand Down
2 changes: 1 addition & 1 deletion build/k8s-container.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# To build and upload a new version of the build container run:
# gcloud container builds submit --config k8s-container.yaml .
# gcloud builds submit --config k8s-container.yaml .

steps:
- name: 'gcr.io/cloud-builders/docker'
Expand Down
12 changes: 6 additions & 6 deletions gcbmgr
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ list_staged_builds () {
# Stream the latest working job log to the console
# @optparam build_id - A specific build id to stream
stream_job_log () {
local build_id=${1:-$($GCLOUD container builds list |\
local build_id=${1:-$($GCLOUD builds list |\
awk '/WORKING/{print $1;exit}')}
#highlighting fix'

Expand All @@ -239,7 +239,7 @@ stream_job_log () {

logecho "Waiting for GCP to initiate stream..."
logecho
$GCLOUD container builds log --stream $build_id
$GCLOUD builds log --stream $build_id
}

###############################################################################
Expand All @@ -266,12 +266,12 @@ list_jobs () {
{
echo "TAGS S ID START($(date +%Z))"
echo "=============== = ===================================== ==============="
$GCLOUD container builds list | sed -n '2,$p' | \
$GCLOUD builds list | sed -n '2,$p' | \
while read id time elapsed source images status; do
[[ $status != "${state:-$status}" ]] && continue
((counter++))

tags=$($GCLOUD container builds describe $id --format=json|\
tags=$($GCLOUD builds describe $id --format=json|\
jq -r '.tags[]' 2>&-)

# Convert time to local time
Expand All @@ -296,7 +296,7 @@ submit_it () {
substitutions+=",_RELEASE_BRANCH=$RELEASE_BRANCH,_OFFICIAL=$OFFICIAL,_RC=$RC"
substitutions+=",_NOMOCK=$NOMOCK,_BUILDVERSION=$BUILDVERSION"

if ! JOB_DATA=$($GCLOUD container builds submit --no-source \
if ! JOB_DATA=$($GCLOUD builds submit --no-source \
--config=$YAML_FILE --async --disk-size=$DISK_SIZE \
--substitutions $substitutions 2>&1); then
logecho "$FAILED: Job was not submitted. Details:"
Expand All @@ -318,7 +318,7 @@ submit_it () {
logecho "To view this specific build:"
logecho "$ $PROG tail $BUILD_ID"
logecho "-OR-"
logecho "$ $GCLOUD container builds log --stream $BUILD_ID"
logecho "$ $GCLOUD builds log --stream $BUILD_ID"
logecho "-OR-"
logecho "$BUILD_URL"
}
Expand Down

0 comments on commit d63e56e

Please sign in to comment.