Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add floryut as a Kubespray maintainer #2374

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Add floryut as a Kubespray maintainer #2374

merged 1 commit into from
Jan 4, 2021

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Dec 9, 2020

@floryut has been driving the past couple of releases of Kubespray (see kubernetes-sigs/kubespray#6535) but doesn't have to forge releases & tags. Let's welcome @floruyt to the maintainer's team.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. labels Dec 9, 2020
@mattymo
Copy link

mattymo commented Dec 9, 2020

+1 from me as an existing maintainer

@Miouge1 Miouge1 force-pushed the floruyt-maintainer branch from 0b01fb8 to 5ec5f06 Compare December 9, 2020 08:35
@floryut
Copy link
Contributor

floryut commented Dec 9, 2020

Wow 😄 Thank you @Miouge1 and @mattymo
You guys rocks

@mrbobbytables
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
nikhita
nikhita approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm-ing based on @Miouge1 and @mattymo's +1s

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miouge1, mrbobbytables, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46ad4b7 into kubernetes:master Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@neolit123 neolit123 Awaiting requested review from neolit123

Assignees

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Miouge1 @mattymo @floryut @mrbobbytables @k8s-ci-robot @nikhita