Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log pattern check configurable in health checker #536

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Make log pattern check configurable in health checker #536

merged 1 commit into from
Feb 18, 2021

Conversation

abansal4032
Copy link
Contributor

This CL makes the log pattern and the threshold configurable through health checker plugin config through flags --log-pattern and --log-pattern-count-threshold respectively. An empty --log-pattern(default) will skip the log pattern check and not mark the service as unhealthy.

@k8s-ci-robot
Copy link
Contributor

Hi @abansal4032. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 17, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 17, 2021
@abansal4032
Copy link
Contributor Author

/cc Random-Liu

Random-Liu
Random-Liu reviewed Feb 17, 2021
View reviewed changes
cmd/healthchecker/options/options.go Outdated
CriSocketPath string
CoolDownTime time.Duration
HealthCheckTimeout time.Duration
LogPattern string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should support multiple log patterns. Can we have a customized flag supporting this, e.g. https://play.golang.org/p/Ig5sm7jA14?

It could be something like this:

health-checker --log-pattern 10:aaaaaa --log-pattern 20:bbbbbb --log-pattern 15:ccccc

Copy link
Contributor Author

@abansal4032 abansal4032 Feb 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Yeah that can be helpful.

Is the idea in the above example --log-pattern threshold_count:pattern?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. If we do pattern:threshold_count, it is possible that the pattern may contain :, and make the parsing harder.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. Changed.

@Random-Liu
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2021
@abansal4032 abansal4032 force-pushed the configure-log-pattern branch 3 times, most recently from c0da157 to c8631bc Compare February 17, 2021 23:57
Random-Liu
Random-Liu reviewed Feb 18, 2021
View reviewed changes
pkg/healthchecker/types/types.go

// LogPatternFlag defines the flag for log pattern health check.
// It contains a map of <log pattern> to <failure threshold for the pattern>
type LogPatternFlag struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a unit test for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added unit tests.

@Random-Liu
Copy link
Member

LGTM, but please add a unit test.

@abansal4032 abansal4032 force-pushed the configure-log-pattern branch from c8631bc to acd2444 Compare February 18, 2021 01:35
@abansal4032 abansal4032 force-pushed the configure-log-pattern branch from acd2444 to 100f2bf Compare February 18, 2021 01:46
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abansal4032, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2021
@Random-Liu
Copy link
Member

/test pull-npd-e2e-test

@k8s-ci-robot k8s-ci-robot merged commit ee5f2d1 into kubernetes:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Random-Liu Random-Liu Random-Liu left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abansal4032 @k8s-ci-robot @Random-Liu