-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more info to disk metrics #452
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @vteratipally. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @ForestCold |
@vteratipally: GitHub didn't allow me to assign the following users: Forestcold. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
pkg/systemstatsmonitor/labels.go
Outdated
@@ -24,3 +24,9 @@ const directionLabel = "direction" | |||
|
|||
// stateLabel labels the state of disk/memory/cpu usage, e.g.: "free", "used". | |||
const stateLabel = "state" | |||
|
|||
// fstypeLabel labels the fst type of the disk, e.g.: "ext4", "ext2", "vfat" | |||
const fstypeLabel = "fstype" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: fstypeLabel/fsTypeLabel?
pkg/systemstatsmonitor/labels.go
Outdated
const fstypeLabel = "fstype" | ||
|
||
// mountPointLabel labels the mountpoint of the monitored disk device | ||
const mountOptionLabel = "mountoption" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that a newline is missing at the end of the file.
/ok-to-test |
/test pull-npd-e2e-kubernetes-gce-gci |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Adds labels to the metric disk_usage_bytes fstypes and mount points as the additional information that would help in analyzing and monitor the use of the file systems