Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete 'vmwarefusion' driver, add friendly message #9958

Merged
merged 2 commits into from
Dec 23, 2020

Conversation

tstromberg
Copy link
Contributor

The vmwarefusion driver has been broken for 6+ months. Fixes #8374

With this PR, this is the behavior when --driver=vmwarefusion is provided:

😄  minikube v1.15.1 on Darwin 10.15.7
✨  Using the vmwarefusion driver based on user configuration

🤷  Exiting due to PROVIDER_VMWAREFUSION_OBSOLETE: The 'vmwarefusion' driver is no longer available
💡  Suggestion: Switch to the newer 'vmware' driver by using '--driver=vmware'. This may require first deleting your existing cluster
📘  Documentation: https://minikube.sigs.k8s.io/docs/drivers/vmware/

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 14, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2020
@sharifelgamal
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 14, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9958): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9958/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9958/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9958): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9958/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9958/minikube: exec format error

@afbjorklund
Copy link
Collaborator

@tstromberg :
Apparently the "newer" vmware driver doesn't support the new versions just yet ?

This driver requires VMware Workstation 14 (Windows/Linux) or VMware Fusion 10 (MacOS) to be installed on your host. Earlier versions of Workstation/Fusion might still work with this driver, but it's not officially supported.

The are issues opened against both Workstation 15 and against Fusion 11.
https://github.com/machine-drivers/docker-machine-driver-vmware/issues

See https://www.vmware.com/products/desktop-hypervisor.html

Interestingly, they recommend minikube for kubernetes even despite that:

How to create a Kubernetes cluster?

You can create and deploy a Kubernetes cluster on either a physical or a virtual machine. It is recommended for new users to start creating a Kubernetes cluster by using Minikube. Minikube is an open-source tool that is compatible with Linux, Mac and
Windows operating systems. Minikube can be used to create and deploy a simple, streamlined cluster that contains only one worker node.

https://www.vmware.com/topics/glossary/content/kubernetes-cluster

@afbjorklund
Copy link
Collaborator

We should still obsolete the "vmwarefusion" driver, just that "vmware" needs fixing too...

@@ -47,7 +47,7 @@ const (
HyperKit = "hyperkit"
// VMware driver
VMware = "vmware"
// VMwareFusion driver
// VMwareFusion driver (obsolete)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just delete it ? That is what we did with kvm and xhyve, for instance (0332f73)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [afbjorklund,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit f680057 into kubernetes:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove obsolete vmwarefusion driver in preference to vmware driver (HostIP not yet implemented)
6 participants