Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Ingress Addon for Docker Windows #9761

Merged
merged 2 commits into from
Dec 17, 2020
Merged

Enable Ingress Addon for Docker Windows #9761

merged 2 commits into from
Dec 17, 2020

Conversation

blueelvis
Copy link
Contributor

Related bug - #7332 but just for Docker on Windows.

Before merging this PR, ensure that this PR is merged - #9753

With this PR,

  1. Enable the Ingress addon for minikube for Docker on Windows.
  2. Add a notice in the output which tells to run minikube tunnel to access the ingress resources.

Output -

PS C:\utilities> .\minikube-windows-amd64.exe addons enable ingress                                                                                           I1121 00:59:39.443965    3000 translate.go:89] Failed to load translation file for en: Asset translations/en.json not found
* After the addon is enabled, please run "minikube tunnel" and your ingress resources would be available at "127.0.0.1"
* Verifying ingress addon...
* The 'ingress' addon is enabled

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2020
@blueelvis blueelvis mentioned this pull request Nov 21, 2020
Merged
medyagh
medyagh requested changes Nov 25, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check lint

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 15, 2020
@tstromberg tstromberg merged commit 02c8f8b into kubernetes:master Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bl-ue, blueelvis, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@blueelvis blueelvis deleted the task/enable-ingress-docker-windows branch December 18, 2020 04:00
@fmotrifork fmotrifork mentioned this pull request Dec 18, 2020
Merged
@maximus1108 maximus1108 mentioned this pull request Jan 11, 2021
Closed
@FrankAnthony11 FrankAnthony11 mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bl-ue bl-ue bl-ue approved these changes

@medyagh medyagh medyagh requested changes

@tstromberg tstromberg tstromberg approved these changes

@prasadkatti prasadkatti Awaiting requested review from prasadkatti

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blueelvis @k8s-ci-robot @tstromberg @medyagh @bl-ue