Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving log message when profile not found #9613

Merged
merged 2 commits into from
Nov 6, 2020
Merged

Improving log message when profile not found #9613

merged 2 commits into from
Nov 6, 2020

Conversation

peterlin741
Copy link
Contributor

@peterlin741 peterlin741 commented Nov 6, 2020

Fixes #9247

  • Updates logging messages with better wording
  • Suggest the user to run "minikube profile list" to view all profiles, instead of recommending a specific profile, since the user can have multiple profiles
  • Ran make extract to update strings (docs)
skellige% ./out/minikube profile list
|------------------|-----------|---------|--------------|------|---------|---------|
|     Profile      | VM Driver | Runtime |      IP      | Port | Version | Status  |
|------------------|-----------|---------|--------------|------|---------|---------|
| minikube-cluster | docker    | docker  | 192.168.49.2 | 8443 | v1.19.2 | Running |
|------------------|-----------|---------|--------------|------|---------|---------|

skellige% ./out/minikube ssh
🤷  Profile "minikube" not found. Run "minikube profile list" to view all profiles.
👉  To start a cluster, run: "minikube start"

skellige% ./out/minikube --profile nonexistant-profile ssh
🤷  Profile "nonexistant-profile" not found. Run "minikube profile list" to view all profiles.
👉  To start a cluster, run: "minikube start -p nonexistant-profile"

Compiling translation strings...
Writing to de.json (51 translated, 687 untranslated)
Writing to es.json (51 translated, 687 untranslated)
Writing to fr.json (161 translated, 577 untranslated)
Writing to ja.json (281 translated, 457 untranslated)
Writing to ko.json (137 translated, 601 untranslated)
Writing to pl.json (82 translated, 656 untranslated)
Writing to zh-CN.json (214 translated, 524 untranslated)
Done! to make sure all strings are up to date
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 6, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @peterlin741!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @peterlin741. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 6, 2020
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@priyawadhwa
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 6, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9613): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9613/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9613/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9613): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9613/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9613/minikube: exec format error

Copy link

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be good to go once CLA is signed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: peterlin741, priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2020
@peterlin741
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 6, 2020
@priyawadhwa priyawadhwa merged commit 31e7b3c into kubernetes:master Nov 6, 2020
@peterlin741 peterlin741 deleted the issue-9247-profile-mssg branch November 6, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve message, when there is profile name other than "minikube"
5 participants