docker: When creating networks, use MTU of built-in bridge network #9530

medyagh · 2020-10-22T23:09:39Z

After this PR

medya@cloudshell:~$ ./minikube-linux-amd64 ssh
docker@minikube:~$ docker pull golang:1.15
1.15: Pulling from library/golang
e4c3d3e4f7b0: Pull complete
101c41d0463b: Pull complete
8275efcd805f: Pull complete
751620502a7a: Pull complete
aaabf962c4fc: Pull complete
7883babec904: Pull complete
1791d366c848: Pull complete
Digest: sha256:1ba0da74b20aad52b091877b0e0ece503c563f39e37aa6b0e46777c4d820a2ae
Status: Downloaded newer image for golang:1.15
docker.io/library/golang:1.15
docker@minikube:~$ 
docker@minikube:~$
docker@minikube:~$
docker@minikube:~$
docker@minikube:~$ exit
logout

gout
medya@cloudshell:~$ docker network inspect minikube
[
    {
        "Name": "minikube",
        "Id": "1d1e52f41e1b8a9ca89c3aba16a9d318251199f57a4b8d15769e1d0673685223",
        "Created": "2020-10-23T21:19:26.083577921Z",
        "Scope": "local",
        "Driver": "bridge",
        "EnableIPv6": false,
        "IPAM": {
            "Driver": "default",
            "Options": {},
            "Config": [
                {
                    "Subnet": "192.168.49.0/24",
                    "Gateway": "192.168.49.1"
                }
            ]
        },
        "Internal": false,
        "Attachable": false,
        "Ingress": false,
        "ConfigFrom": {
            "Network": ""
        },
        "ConfigOnly": false,
        "Containers": {
            "8d3585732ce0878bf5c85fabb3be2e0b72ea181baa7fc3f0299c0188c2ff9d1f": {
                "Name": "minikube",
                "EndpointID": "5810c510b63c76af8d8759e92d72624dc008f06b7eadb2f5aadae43b6bfea146",
                "MacAddress": "02:42:c0:a8:31:02",
                "IPv4Address": "192.168.49.2/24",
                "IPv6Address": ""
            }
        },
        "Options": {
            "--icc": "",
            "--ip-masq": "",
            "com.docker.network.driver.mtu": "1460"
        },
        "Labels": {
            "created_by.minikube.sigs.k8s.io": "true"
        }
    }
]

medyagh · 2020-10-22T23:09:47Z

/ok-to-test

minikube-pr-bot · 2020-10-22T23:15:16Z

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9530): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9530/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9530/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9530): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9530/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9530/minikube: exec format error

minikube-pr-bot · 2020-10-23T00:15:10Z

kvm2 Driver
Times for minikube: 62.5s 59.4s 57.6s
Average time for minikube: 59.8s

Times for Minikube (PR 9530): 61.6s 60.1s 61.8s
Average time for Minikube (PR 9530): 61.2s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.1s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 33.3s    | 35.8s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.2s    | 23.4s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.5s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.6s     | 0.5s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.2s 27.7s 28.3s
Average time for minikube: 28.4s

Times for Minikube (PR 9530): 28.4s 27.6s 29.5s
Average time for Minikube (PR 9530): 28.5s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.8s     | 8.9s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.2s    | 18.1s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.0s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

minikube-pr-bot · 2020-10-23T00:44:42Z

kvm2 Driver
Times for minikube: 62.1s 60.5s 59.1s
Average time for minikube: 60.6s

Times for Minikube (PR 9530): 61.6s 60.2s 60.9s
Average time for Minikube (PR 9530): 60.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.1s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 34.4s    | 35.4s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.8s    | 23.6s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.5s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.5s     | 0.7s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 28.6s 27.0s 27.8s
Average time for minikube: 27.8s

Times for Minikube (PR 9530): 28.7s 26.8s 28.8s
Average time for Minikube (PR 9530): 28.1s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.8s     | 8.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 17.4s    | 17.8s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.3s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.1s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

pkg/drivers/kic/oci/network_create.go

minikube-pr-bot · 2020-10-23T19:56:19Z

kvm2 Driver
Times for minikube: 60.6s 61.8s 61.1s
Average time for minikube: 61.2s

Times for Minikube (PR 9530): 61.9s 58.3s 56.0s
Average time for Minikube (PR 9530): 58.8s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.1s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.7s    | 32.6s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 22.1s    | 24.1s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.5s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.7s 31.1s 29.2s
Average time for minikube: 30.0s

Times for Minikube (PR 9530): 29.1s 28.1s 29.2s
Average time for Minikube (PR 9530): 28.8s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.2s     | 9.0s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 19.2s    | 18.3s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.2s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

minikube-pr-bot · 2020-10-23T20:55:35Z

kvm2 Driver
Times for minikube: 62.0s 61.6s 60.4s
Average time for minikube: 61.3s

Times for Minikube (PR 9530): 58.7s 63.0s 59.5s
Average time for Minikube (PR 9530): 60.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.1s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.1s    | 35.7s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.2s    | 22.5s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.8s     | 1.7s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.2s     |                    |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.1s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.0s 28.2s 28.4s
Average time for minikube: 28.5s

Times for Minikube (PR 9530): 28.6s 29.6s 30.0s
Average time for Minikube (PR 9530): 29.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.8s     | 9.0s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 18.4s    | 18.8s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 0.9s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.3s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

minikube-pr-bot · 2020-10-23T21:25:11Z

kvm2 Driver
Times for minikube: 65.1s 58.9s 60.2s
Average time for minikube: 61.4s

Times for Minikube (PR 9530): 60.7s 62.8s 61.8s
Average time for Minikube (PR 9530): 61.7s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 34.8s    | 35.6s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 24.3s    | 24.4s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.7s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 29.8s 29.3s 29.3s
Average time for minikube: 29.5s

Times for Minikube (PR 9530): 27.6s 27.5s 27.8s
Average time for Minikube (PR 9530): 27.6s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 8.9s     | 8.9s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 19.0s    | 17.2s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.2s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

pkg/drivers/kic/oci/network_create.go

priyawadhwa · 2020-10-23T21:43:55Z

compilation error:

level=error msg="Running error: buildir: analysis skipped: errors in package: [/home/runner/work/minikube/minikube/pkg/drivers/kic/oci/network_create.go:125:2: undeclared name: inf -: could not load export data: no export data for \"k8s.io/minikube/pkg/drivers/kic/oci\"]"

pkg/drivers/kic/oci/network_create.go

tstromberg

Have some minor readability comments, but logic is solid. Merge when comfortable.

minikube-pr-bot · 2020-10-23T22:04:48Z

kvm2 Driver
Times for minikube: 62.9s 59.7s 61.9s
Average time for minikube: 61.5s

Times for Minikube (PR 9530): 59.0s 60.2s 58.6s
Average time for Minikube (PR 9530): 59.3s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.1s     | 0.0s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 35.8s    | 35.0s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.2 | 23.4s    | 22.2s              |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.5s     | 0.4s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 30.0s 29.0s 30.0s
Average time for minikube: 29.7s

Times for Minikube (PR 9530): 28.6s 28.6s 28.9s
Average time for Minikube (PR 9530): 28.7s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9530) |
+--------------------------------+----------+--------------------+
| * minikube v1.14.0 on Debian   | 0.2s     | 0.2s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.1s     | 0.1s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.1s     | 9.1s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.2 | 19.1s    | 18.2s              |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.1s     | 1.0s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| storage-provisioner,           |          |                    |
| default-storageclass           |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.2? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

k8s-ci-robot · 2020-10-23T22:37:32Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh, priyawadhwa, tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh,priyawadhwa,tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

lower mtu for cloud shell

a6e5fb8

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 22, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2020

k8s-ci-robot requested review from afbjorklund and josedonizetti October 22, 2020 23:09

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2020

fix option

bfa83ff

try

50a04a4

tstromberg reviewed Oct 23, 2020

View reviewed changes

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

medyagh changed the title ~~wip: lower mtu for cloud shell~~ Set the MTU for the docker network Oct 23, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 23, 2020

tstromberg mentioned this pull request Oct 23, 2020

Enable TCP Path MTU Discovery when an ICMP black hole is detected #9537

Merged

detect MTU from docker brdige

cde546e

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 23, 2020

lint

94485d5

tstromberg reviewed Oct 23, 2020

View reviewed changes

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

make struct for netinfo

aa97aca

medyagh added 2 commits October 23, 2020 14:07

template

1dd5583

log

4993dc6

medyagh requested a review from priyawadhwa October 23, 2020 21:27

medyagh requested a review from tstromberg October 23, 2020 21:27

tstromberg changed the title ~~Set the MTU for the docker network~~ docker: When creating networks, use MTU of built-in bridge network Oct 23, 2020

tstromberg reviewed Oct 23, 2020

View reviewed changes

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

priyawadhwa approved these changes Oct 23, 2020

View reviewed changes

dont pass mtu if 0

43c2a5c

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 23, 2020

tstromberg suggested changes Oct 23, 2020

View reviewed changes

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

pkg/drivers/kic/oci/network_create.go Outdated Show resolved Hide resolved

tstromberg approved these changes Oct 23, 2020

View reviewed changes

readability

9f729ac

tstromberg approved these changes Oct 23, 2020

View reviewed changes

medyagh merged commit a012248 into kubernetes:master Oct 23, 2020

fmotrifork mentioned this pull request Oct 26, 2020

minikube 1.14.1 fishworks/fish-food#1028

Merged

medyagh deleted the mini_mtu branch March 2, 2021 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docker: When creating networks, use MTU of built-in bridge network #9530

docker: When creating networks, use MTU of built-in bridge network #9530

medyagh commented Oct 22, 2020 •

edited

Loading

medyagh commented Oct 22, 2020

minikube-pr-bot commented Oct 22, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

priyawadhwa commented Oct 23, 2020

tstromberg left a comment

minikube-pr-bot commented Oct 23, 2020

k8s-ci-robot commented Oct 23, 2020

docker: When creating networks, use MTU of built-in bridge network #9530

docker: When creating networks, use MTU of built-in bridge network #9530

Conversation

medyagh commented Oct 22, 2020 • edited Loading

After this PR

medyagh commented Oct 22, 2020

minikube-pr-bot commented Oct 22, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

minikube-pr-bot commented Oct 23, 2020

priyawadhwa commented Oct 23, 2020

tstromberg left a comment

Choose a reason for hiding this comment

minikube-pr-bot commented Oct 23, 2020

k8s-ci-robot commented Oct 23, 2020

medyagh commented Oct 22, 2020 •

edited

Loading