Update DefaultKubernetesVersion to v1.19.2 #9265

tstromberg · 2020-09-17T00:46:01Z

https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#changelog-since-v1191

Fix conversions for custom metrics. (Automated cherry pick of #94481 #94639 upstream release 1.19 kubernetes#94654, @wojtek-t) [SIG Instrumentation]
Fixed a panic in kubectl debug when pod has multiple init containers or ephemeral containers (Fix index out of range panic for kubectl alpha debug kubernetes#94580, @kiyoshim55) [SIG CLI]
Update CNI plugins to v0.8.7 (Update CNI plugins to v0.8.7 kubernetes#94367, @justaugustus) [SIG Cloud Provider, Network, Node, Release and Testing]

tstromberg · 2020-09-17T00:46:15Z

/ok-to-test

k8s-ci-robot · 2020-09-17T00:46:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [tstromberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

TravisBuddy · 2020-09-17T00:55:09Z

Travis tests have failed

Hey @tstromberg,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.13.0 -X k8s.io/minikube/pkg/version.isoVersion=v1.13.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="72fd80028575b201a9f86a788726cf22b69135ef" -X k8s.io/minikube/pkg/version.storageProvisionerVersion=v3" ./test.sh
= make lint =============================================================
golangci/golangci-lint info checking GitHub for tag 'v1.30.0'
golangci/golangci-lint info found version: 1.30.0 for v1.30.0/linux/amd64
golangci/golangci-lint info installed out/linters/golangci-lint
pkg/drivers/kic/oci/oci.go:110:1: cyclomatic complexity 31 of func `CreateContainerNode` is high (> 30) (gocyclo)
func CreateContainerNode(p CreateParams) error {
^
Makefile:433: recipe for target 'lint-ci' failed
make[1]: *** [lint-ci] Error 1
= go mod ================================================================
unused golang.org/x/exp
ok
= boilerplate ===========================================================
ok
Makefile:314: recipe for target 'test' failed
make: *** [test] Error 4
travis_time:end:05d453be:start=1600303686878766747,finish=1600303899244695851,duration=212365929104,event=script

TravisBuddy Request Identifier: 6cf96f10-f880-11ea-8f9f-a900ee46d44b

minikube-pr-bot · 2020-09-17T01:09:15Z

kvm2 Driver
Times for minikube: 64.7s 63.1s 62.5s
Average time for minikube: 63.4s

Times for Minikube (PR 9265): 96.5s 93.1s 91.8s
Average time for Minikube (PR 9265): 93.8s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9265) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 37.0s    | 19.6s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.1 | 24.1s    |                    |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.8s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.6s     | 0.5s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 71.7s              |
| * Want kubectl v1.19.1? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 31.7s 30.1s 29.6s
Average time for minikube: 30.5s

Times for Minikube (PR 9265): 57.4s 60.8s 58.6s
Average time for Minikube (PR 9265): 58.9s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9265) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.2s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.3s     | 5.8s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.1 | 19.7s    |                    |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 1.0s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.1? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

tstromberg · 2020-09-17T01:16:17Z

Lint issue is unrelated to this PR.

pkg/drivers/kic/oci/oci.go:110:1: cyclomatic complexity 31 of func `CreateContainerNode` is high (> 30) (gocyclo)
func CreateContainerNode(p CreateParams) error {
^
make[1]: *** [lint-ci] Error 1
Makefile:433: recipe for target 'lint-ci' failed

tstromberg · 2020-09-17T15:29:31Z

/ok-to-test

minikube-pr-bot · 2020-09-18T19:05:23Z

kvm2 Driver
Times for minikube: 65.4s 62.5s 64.1s
Average time for minikube: 64.0s

Times for Minikube (PR 9265): 68.8s 61.6s 62.8s
Average time for Minikube (PR 9265): 64.4s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9265) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the kvm2 driver based  | 0.0s     | 0.0s               |
| on user configuration          |          |                    |
| * Starting control plane node  | 0.0s     | 0.0s               |
| minikube in cluster minikube   |          |                    |
| * Creating kvm2 VM (CPUs=2,    | 36.5s    | 37.8s              |
| Memory=3700MB, Disk=20000MB)   |          |                    |
| ...                            |          |                    |
| * Preparing Kubernetes v1.19.1 | 25.1s    |                    |
| on Docker 19.03.12 ...         |          |                    |
| * Verifying Kubernetes         | 1.6s     | 1.6s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.7s     | 0.2s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.1? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

docker Driver
Times for minikube: 43.2s 31.9s 31.5s
Average time for minikube: 35.5s

Times for Minikube (PR 9265): 31.6s 29.9s 28.9s
Average time for Minikube (PR 9265): 30.2s

Averages Time Per Log

+--------------------------------+----------+--------------------+
|              LOG               | MINIKUBE | MINIKUBE (PR 9265) |
+--------------------------------+----------+--------------------+
| * minikube v1.13.0 on Debian   | 0.1s     | 0.1s               |
|                           9.11 |          |                    |
| * Using the docker driver      | 0.2s     | 0.2s               |
| based on user configuration    |          |                    |
| * Starting control plane node  | 0.1s     | 0.1s               |
| minikube in cluster minikube   |          |                    |
| * Creating docker container    | 9.4s     | 8.9s               |
| (CPUs=2, Memory=3700MB) ...    |          |                    |
| * Preparing Kubernetes v1.19.1 | 21.3s    |                    |
| on Docker 19.03.8 ...          |          |                    |
| * Verifying Kubernetes         | 4.4s     | 1.1s               |
| components...                  |          |                    |
| * Enabled addons:              | 0.1s     | 0.1s               |
| default-storageclass,          |          |                    |
| storage-provisioner            |          |                    |
|                                | 0.0s     | 0.0s               |
| * Want kubectl v1.19.1? Try    |          |                    |
| 'minikube kubectl -- get pods  |          |                    |
| -A'                            |          |                    |
| * Done! kubectl is now         |          |                    |
| configured to use "minikube"   |          |                    |
| by default                     |          |                    |
+--------------------------------+----------+--------------------+

Update DefaultKubernetesVersion to v1.19.2

942eb53

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2020

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Sep 17, 2020

k8s-ci-robot requested review from afbjorklund and prasadkatti September 17, 2020 00:46

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020

tstromberg requested review from sharifelgamal and afbjorklund and removed request for afbjorklund September 17, 2020 00:46

Merge branch 'master' into v1.19.2

464a742

medyagh approved these changes Sep 18, 2020

View reviewed changes

sharifelgamal merged commit 615b05b into kubernetes:master Sep 18, 2020

fmotrifork mentioned this pull request Sep 22, 2020

minikube 1.13.1 fishworks/fish-food#976

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update DefaultKubernetesVersion to v1.19.2 #9265

Update DefaultKubernetesVersion to v1.19.2 #9265

tstromberg commented Sep 17, 2020

tstromberg commented Sep 17, 2020

k8s-ci-robot commented Sep 17, 2020

TravisBuddy commented Sep 17, 2020

minikube-pr-bot commented Sep 17, 2020

tstromberg commented Sep 17, 2020

tstromberg commented Sep 17, 2020

minikube-pr-bot commented Sep 18, 2020

Update DefaultKubernetesVersion to v1.19.2 #9265

Update DefaultKubernetesVersion to v1.19.2 #9265

Conversation

tstromberg commented Sep 17, 2020

tstromberg commented Sep 17, 2020

k8s-ci-robot commented Sep 17, 2020

TravisBuddy commented Sep 17, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 6cf96f10-f880-11ea-8f9f-a900ee46d44b

minikube-pr-bot commented Sep 17, 2020

tstromberg commented Sep 17, 2020

tstromberg commented Sep 17, 2020

minikube-pr-bot commented Sep 18, 2020