Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min*Mem constants to use MiB instead of MB #9180

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Sep 3, 2020

At some point, minikube changed from MB to MiB internally, but the constants were never updated.

This fixes the confusing behavior when a user sets Docker to 2GB (1907MiB), but we still warn because it is less than 2000.

This also fixes it so that minikube does not force exit if Docker is set to 1GB of RAM (953MiB), which is acceptable enough for Kubernetes, leaving 200MiB to spare.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2020
@priyawadhwa priyawadhwa merged commit f7b120a into kubernetes:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants