advice user when allocate more than 80% of their memory #8877

medyagh · 2020-07-29T20:40:34Z

closes this #8708
also fixed a bug that the advice was showing twice.
and also fixed the bug that we were not checking for allowing max
also moves all the calls to getting CPU/memory info into a cached func for less overhead

before this PR

allowing more than max memory was allowed.

after this PR on a macbook with 16 GB ram

Don't allow 17GB

medya@~/workspace/minikube (max_memory) $ make && ./out/minikube start --driver=hyperkit --memory=17gb

😄  minikube v1.12.1 on Darwin 10.15.6
✨  Using the hyperkit driver based on user configuration
💡  To suppress memory validations you can use --force flag.
💣  Requested memory allocation 17408MB is more than your system limit 16384MB. Try specifying a lower memory:

        miniube start --memory=8192mb

Advice more than 80% allocation.


medya@~/workspace/minikube (max_memory) $ make && ./out/minikube start --driver=hyperkit --memory=15gb
make: `out/minikube' is up to date.
😄  minikube v1.12.1 on Darwin 10.15.6
✨  Using the hyperkit driver based on user configuration
❗  You are allocating 15360MB to memory and your system only has 16384MB. You might face issues. try specifying a lower memory:

                miniube start --memory=8192mb


💡  To suppress and ignore this warning you can use --force flag.
👍  Starting control plane node minikube in cluster minikube
🔥  Creating hyperkit VM (CPUs=2, Memory=15360MB, Disk=20000MB) ...

k8s-ci-robot · 2020-07-29T20:41:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/minikube/cmd/start.go

TravisBuddy · 2020-08-03T21:47:42Z

Travis tests have failed

Hey @medyagh,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

make test

which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/assets/assets.go -pkg assets deploy/addons/...
gofmt -s -w pkg/minikube/assets/assets.go
which go-bindata || GO111MODULE=off GOBIN="/home/travis/gopath/bin" go get github.com/jteeuwen/go-bindata/...
/home/travis/gopath/bin/go-bindata
PATH="/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.14.6.linux.amd64/bin:/home/travis/bin:/home/travis/bin:/home/travis/.local/bin:/usr/local/lib/jvm/openjdk11/bin:/opt/pyenv/shims:/home/travis/.phpenv/shims:/home/travis/perl5/perlbrew/bin:/home/travis/.nvm/versions/node/v8.12.0/bin:/home/travis/.rvm/gems/ruby-2.5.3/bin:/home/travis/.rvm/gems/ruby-2.5.3@global/bin:/home/travis/.rvm/rubies/ruby-2.5.3/bin:/home/travis/gopath/bin:/home/travis/.gimme/versions/go1.11.1.linux.amd64/bin:/usr/local/maven-3.6.3/bin:/usr/local/cmake-3.12.4/bin:/usr/local/clang-7.0.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/home/travis/.rvm/bin:/home/travis/.phpenv/bin:/opt/pyenv/bin:/home/travis/.yarn/bin:/home/travis/gopath/bin" go-bindata -nomemcopy -o pkg/minikube/translate/translations.go -pkg translate translations/...
gofmt -s -w pkg/minikube/translate/translations.go
MINIKUBE_LDFLAGS="-X k8s.io/minikube/pkg/version.version=v1.12.1 -X k8s.io/minikube/pkg/version.isoVersion=v1.12.0 -X k8s.io/minikube/pkg/version.isoPath=minikube/iso -X k8s.io/minikube/pkg/version.gitCommitID="a8f4cb11d3f675448e6fda6ab69ca7f7487a59ba"" ./test.sh
= schema_check ==========================================================
go: downloading github.com/xeipuuv/gojsonschema v0.0.0-20180618132009-1d523034197f
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
ok
= go test ===============================================================
go: downloading github.com/spf13/cobra v1.0.0
go: downloading github.com/machine-drivers/machine v0.7.1-0.20200323212942-41eb826190d8
go: downloading k8s.io/apimachinery v0.17.3
go: downloading github.com/blang/semver v3.5.0+incompatible
go: downloading github.com/cloudevents/sdk-go/v2 v2.1.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading k8s.io/kubectl v0.17.3
go: downloading cloud.google.com/go v0.57.0
go: downloading k8s.io/client-go v0.17.3
go: downloading github.com/afbjorklund/go-containerregistry v0.0.0-20200602203322-347d93793dc9
go: downloading github.com/spf13/pflag v1.0.5
go: downloading golang.org/x/oauth2 v0.0.0-20200107190931-bf48bf16ab8d
go: downloading google.golang.org/api v0.25.0
go: downloading github.com/mitchellh/go-ps v0.0.0-20190716172923-621e5597135b
go: downloading github.com/shirou/gopsutil v2.18.12+incompatible
go: downloading k8s.io/api v0.17.3
go: downloading golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a
go: downloading golang.org/x/crypto v0.0.0-20200510223506-06a226fb4e37
go: downloading github.com/pkg/browser v0.0.0-20160118053552-9302be274faa
go: downloading cloud.google.com/go/storage v1.8.0
go: downloading github.com/afbjorklund/go-getter v1.4.1-0.20190910175809-eb9f6c26742c
go: downloading gopkg.in/yaml.v2 v2.3.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading google.golang.org/genproto v0.0.0-20200527145253-8367513e4ece
go: downloading github.com/pkg/profile v0.0.0-20161223203901-3a8809bd8a80
go: downloading github.com/opencontainers/go-digest v1.0.0-rc1
go: downloading github.com/spf13/viper v1.7.0
go: downloading github.com/aws/aws-sdk-go v1.31.6
go: downloading github.com/ulikunitz/xz v0.5.7
go: downloading github.com/mitchellh/go-testing-interface v1.0.0
go: downloading golang.org/x/sys v0.0.0-20200523222454-059865788121
go: downloading github.com/gogo/protobuf v1.3.1
go: downloading github.com/cpuguy83/go-md2man v1.0.10
go: downloading github.com/magiconair/properties v1.8.1
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/golang/glog v0.0.0-20160126235308-23def4e6c14b
go: downloading go.opencensus.io v0.22.3
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0
go: downloading github.com/mitchellh/mapstructure v1.3.1
go: downloading github.com/olekukonko/tablewriter v0.0.4
go: downloading github.com/spf13/afero v1.2.2
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading golang.org/x/text v0.3.2
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading github.com/docker/docker v1.4.2-0.20190924003213-a8608b5b67c7
go: downloading github.com/hashicorp/go-version v1.2.0
go: downloading github.com/russross/blackfriday v1.5.3-0.20200218234912-41c5fccfd6f6
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner v4.0.0+incompatible
go: downloading github.com/intel-go/cpuid v0.0.0-20181003105527-1a4a6f06a1c6
go: downloading github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d
go: downloading k8s.io/kubernetes v1.17.3
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading github.com/juju/clock v0.0.0-20190205081909-9c5c9712527c
go: downloading k8s.io/utils v0.0.0-20200229041039-0a110f9eb7ab
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading github.com/MakeNowJust/heredoc v0.0.0-20170808103936-bb23615498cd
go: downloading github.com/libvirt/libvirt-go v3.4.0+incompatible
go: downloading github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51
go: downloading github.com/otiai10/copy v1.0.2
go: downloading golang.org/x/net v0.0.0-20200520182314-0ba52f642ac2
go: downloading github.com/golang/protobuf v1.4.2
go: downloading sigs.k8s.io/sig-storage-lib-external-provisioner/v5 v5.0.0
go: downloading google.golang.org/protobuf v1.24.0
go: downloading github.com/juju/mutex v0.0.0-20180619145857-d21b13acf4bf
go: downloading github.com/imdario/mergo v0.3.9
go: downloading github.com/subosito/gotenv v1.2.0
go: downloading gopkg.in/ini.v1 v1.56.0
go: downloading golang.org/x/time v0.0.0-20200416051211-89c76fbcd5d1
go: downloading k8s.io/klog v1.0.0
go: downloading github.com/mattn/go-isatty v0.0.12
go: downloading github.com/prometheus/client_golang v1.4.1
go: downloading github.com/hashicorp/go-safetemp v1.0.0
go: downloading k8s.io/cluster-bootstrap v0.17.3
go: downloading github.com/juju/errors v0.0.0-20190806202954-0232dcc7464d
go: downloading google.golang.org/grpc v1.29.1
go: downloading github.com/google/uuid v1.1.1
go: downloading github.com/hashicorp/golang-lru v0.5.3
go: downloading github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
go: downloading go.uber.org/zap v1.10.0
go: downloading github.com/pelletier/go-toml v1.8.0
go: downloading github.com/sayboras/dockerclient v1.0.0
go: downloading github.com/mattn/go-runewidth v0.0.7
go: downloading github.com/cheggaaa/pb v1.0.27
go: downloading sigs.k8s.io/yaml v1.1.0
go: downloading github.com/fsnotify/fsnotify v1.4.9
go: downloading github.com/json-iterator/go v1.1.9
go: downloading go.uber.org/multierr v1.1.0
go: downloading github.com/spf13/cast v1.3.1
go: downloading github.com/hashicorp/go-cleanhttp v0.5.1
go: downloading github.com/cheggaaa/pb/v3 v3.0.1
go: downloading github.com/prometheus/common v0.9.1
go: downloading github.com/machine-drivers/docker-machine-driver-vmware v0.1.1
go: downloading github.com/golang-collections/collections v0.0.0-20130729185459-604e922904d3
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading k8s.io/kube-proxy v0.17.3
go: downloading k8s.io/kubelet v0.17.3
go: downloading github.com/docker/cli v0.0.0-20200303162255-7d407207c304
go: downloading github.com/cespare/xxhash v1.1.0
go: downloading github.com/jmespath/go-jmespath v0.3.0
go: downloading github.com/mitchellh/go-wordwrap v1.0.0
go: downloading k8s.io/component-base v0.17.3
go: downloading github.com/VividCortex/ewma v1.1.1
go: downloading github.com/cespare/xxhash/v2 v2.1.1
go: downloading github.com/opencontainers/image-spec v1.0.1
go: downloading github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd
go: downloading github.com/cenkalti/backoff v2.2.1+incompatible
go: downloading go.uber.org/atomic v1.4.0
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/hooklift/iso9660 v0.0.0-20170318115843-1cf07e5970d8
go: downloading k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a
go: downloading github.com/googleapis/gax-go v2.0.2+incompatible
go: downloading github.com/google/gofuzz v1.0.0
go: downloading github.com/prometheus/procfs v0.0.8
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/googleapis/gax-go/v2 v2.0.5
go: downloading github.com/cloudfoundry-attic/jibber_jabber v0.0.0-20151120183258-bcc4c8345a21
go: downloading github.com/mattn/go-colorable v0.1.6
go: downloading github.com/google/slowjam v0.0.0-20200530021616-df27e642fe7b
go: downloading github.com/miekg/dns v1.1.27
go: downloading github.com/modern-go/reflect2 v1.0.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading github.com/googleapis/gnostic v0.3.0
go: downloading github.com/fatih/color v1.9.0
go: downloading github.com/sirupsen/logrus v1.6.0
go: downloading github.com/containerd/containerd v1.3.1-0.20191213020239-082f7e3aed57
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading gopkg.in/inf.v0 v0.9.1
go: downloading github.com/c4milo/gotoolkit v0.0.0-20170318115440-bcc06269efa9
go: downloading github.com/lightstep/tracecontext.go v0.0.0-20181129014701-1757c391b1ac
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/docker/spdystream v0.0.0-20160310174837-449fdfce4d96
go: downloading github.com/google/go-cmp v0.4.1
go: downloading github.com/docker/docker-credential-helpers v0.6.3
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/evanphx/json-patch v4.5.0+incompatible
go: downloading golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543
ok  	k8s.io/minikube/cmd/minikube/cmd	3.870s	coverage: 18.8% of statements
ok  	k8s.io/minikube/cmd/minikube/cmd/config	0.043s	coverage: 21.5% of statements
E0803 21:46:14.977521   12237 out.go:144] [unset errFile]: * 
E0803 21:46:14.977746   12237 out.go:144] [unset errFile]: X Error getting primary control plane: remove /tmp/profile758115713/.minikube/profiles/config.json: no such file or directory
E0803 21:46:14.977762   12237 out.go:144] [unset errFile]: * 
E0803 21:46:14.977775   12237 out.go:144] [unset errFile]: * minikube is exiting due to an error. If the above message is not useful, open an issue:
E0803 21:46:14.977785   12237 out.go:144] [unset errFile]:   - https://github.com/kubernetes/minikube/issues/new/choose
FAIL	k8s.io/minikube/pkg/addons	0.090s
ok  	k8s.io/minikube/pkg/drivers	0.008s	coverage: 19.6% of statements
ok  	k8s.io/minikube/pkg/drivers/hyperkit	0.003s	coverage: 77.3% of statements
ok  	k8s.io/minikube/pkg/drivers/kic/oci	0.010s	coverage: 0.0% of statements
ok  	k8s.io/minikube/pkg/drivers/kvm	0.023s	coverage: 2.3% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper	0.718s	coverage: 55.7% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil	0.126s	coverage: 62.4% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/bsutil/ktmpl	0.011s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/bootstrapper/images	0.004s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/cluster	0.052s	coverage: 15.3% of statements
ok  	k8s.io/minikube/pkg/minikube/command	0.026s	coverage: 4.3% of statements
ok  	k8s.io/minikube/pkg/minikube/config	0.155s	coverage: 70.0% of statements
ok  	k8s.io/minikube/pkg/minikube/cruntime	0.078s	coverage: 36.6% of statements
ok  	k8s.io/minikube/pkg/minikube/docker	0.025s	coverage: 20.8% of statements
ok  	k8s.io/minikube/pkg/minikube/driver	0.028s	coverage: 34.9% of statements
ok  	k8s.io/minikube/pkg/minikube/extract	0.012s	coverage: 58.8% of statements
ok  	k8s.io/minikube/pkg/minikube/image	0.030s	coverage: 3.0% of statements
ok  	k8s.io/minikube/pkg/minikube/kubeconfig	0.059s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/localpath	0.010s	coverage: 49.3% of statements
ok  	k8s.io/minikube/pkg/minikube/logs	0.042s	coverage: 1.3% of statements
ok  	k8s.io/minikube/pkg/minikube/machine	1.340s	coverage: 39.0% of statements
ok  	k8s.io/minikube/pkg/minikube/notify	0.016s	coverage: 92.9% of statements
ok  	k8s.io/minikube/pkg/minikube/out	0.057s	coverage: 58.7% of statements
ok  	k8s.io/minikube/pkg/minikube/out/register	0.009s	coverage: 54.5% of statements
ok  	k8s.io/minikube/pkg/minikube/perf	4.233s	coverage: 33.8% of statements
ok  	k8s.io/minikube/pkg/minikube/problem	0.018s	coverage: 92.7% of statements
ok  	k8s.io/minikube/pkg/minikube/proxy	0.010s	coverage: 77.0% of statements
ok  	k8s.io/minikube/pkg/minikube/registry	0.010s	coverage: 75.5% of statements
ok  	k8s.io/minikube/pkg/minikube/service	0.081s	coverage: 84.2% of statements
ok  	k8s.io/minikube/pkg/minikube/shell	0.009s	coverage: 97.1% of statements
ok  	k8s.io/minikube/pkg/minikube/storageclass	0.033s	coverage: 100.0% of statements
ok  	k8s.io/minikube/pkg/minikube/sysinit	0.029s	coverage: 6.5% of statements
ok  	k8s.io/minikube/pkg/minikube/translate	0.004s	coverage: 10.5% of statements
ok  	k8s.io/minikube/pkg/minikube/tunnel	1.631s	coverage: 64.2% of statements
ok  	k8s.io/minikube/pkg/util	0.559s	coverage: 77.9% of statements
ok  	k8s.io/minikube/pkg/util/lock	0.004s	coverage: 18.2% of statements
ok  	k8s.io/minikube/pkg/util/retry	0.003s	coverage: 0.0% of statements
FAIL
Makefile:274: recipe for target 'test' failed
make: *** [test] Error 32

TravisBuddy Request Identifier: f35a20c0-d5d2-11ea-8ca9-c37e1b84d109

medyagh · 2020-08-03T21:55:14Z

/ok-to-test

pkg/minikube/machine/info.go

cmd/minikube/cmd/start.go

minikube-pr-bot · 2020-08-03T22:03:32Z

kvm2 Driver
docker Driver

minikube-pr-bot · 2020-08-03T22:53:50Z

kvm2 Driver
Times for minikube: [66.88471992000001 63.097021052 65.588910261]
Average time for minikube: 65.19021707766667

Times for Minikube (PR 8877): [62.1616426 66.500419869 64.65098408]
Average time for Minikube (PR 8877): 64.437682183

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8877) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.072777 |           0.066057 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.022070 |           0.023103 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003169 |           0.002819 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.148815 |          40.765714 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 22.030518 |          21.098050 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.584788 |           1.609078 |
| components...                  |           |                    |
| * Enabled addons:              |  0.238503 |           0.788115 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079308 |           0.076544 |
| configured to use "minikube"   |           |                    |
|                                |  0.010269 |           0.008204 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.721090999999998 29.724293951 28.57615669]
Average time for minikube: 29.340513880333333

Times for Minikube (PR 8877): [28.527804144000005 29.295718317 29.27086756]
Average time for Minikube (PR 8877): 29.03146334033333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8877) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.089549 |           0.093915 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.124703 |           0.118502 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.068628 |           0.068013 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  9.793944 |           9.365965 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 18.220638 |          18.296775 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.969987 |           1.011996 |
| components...                  |           |                    |
| * Enabled addons:              |  0.002667 |           0.002764 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.065279 |           0.067838 |
| configured to use "minikube"   |           |                    |
|                                |  0.005119 |           0.005695 |
+--------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-08-04T06:00:06Z

kvm2 Driver
Times for minikube: [65.027834674 63.945180708999985 63.842232554999995]
Average time for minikube: 64.27174931266666

Times for Minikube (PR 8877): [63.64226325999999 64.97836213000001 62.695563652000004]
Average time for Minikube (PR 8877): 63.772063014

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8877) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.070711 |           0.064816 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.025261 |           0.023694 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003559 |           0.004129 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.521174 |          40.496316 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 21.371587 |          21.011391 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.455711 |           1.524285 |
| components...                  |           |                    |
| * Enabled addons:              |  0.739470 |           0.555126 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079949 |           0.082808 |
| configured to use "minikube"   |           |                    |
|                                |  0.004326 |           0.009496 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [30.013191492000004 28.426180399 28.236955071]
Average time for minikube: 28.89210898733334

Times for Minikube (PR 8877): [28.518503346 29.488091657999995 29.439704872000007]
Average time for Minikube (PR 8877): 29.148766625333334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8877) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.085931 |           0.092168 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.113215 |           0.115475 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.064591 |           0.065345 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  9.256191 |           9.349518 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 18.173098 |          18.458522 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.071931 |           0.984874 |
| components...                  |           |                    |
| * Enabled addons:              |  0.055022 |           0.006449 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.067004 |           0.068730 |
| configured to use "minikube"   |           |                    |
|                                |  0.005124 |           0.007686 |
+--------------------------------+-----------+--------------------+

medyagh · 2020-08-04T07:47:29Z

/retest-this-please

minikube-pr-bot · 2020-08-04T17:07:31Z

kvm2 Driver
Times for minikube: [70.25543791599999 64.116950851 64.30312895000002]
Average time for minikube: 66.22517257233334

Times for Minikube (PR 8877): [67.537446893 62.35665769999999 62.48296404899999]
Average time for Minikube (PR 8877): 64.12568954733334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8877) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.072067 |           0.066971 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021940 |           0.022773 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003409 |           0.003219 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.646568 |          40.070754 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 22.121296 |          21.582719 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.566742 |           1.528431 |
| components...                  |           |                    |
| * Enabled addons:              |  0.705635 |           0.765892 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.081734 |           0.078321 |
| configured to use "minikube"   |           |                    |
|                                |  0.005781 |           0.006609 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.950222954999997 28.439801812 40.29198555699999]
Average time for minikube: 32.89400344133333

Times for Minikube (PR 8877): [28.592749574999996 29.681049198000004 28.782621994]
Average time for Minikube (PR 8877): 29.01880692233333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8877) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.1 on Debian   |  0.093520 |           0.091059 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.119541 |           0.119487 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.068150 |           0.070197 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  9.518489 |           9.511417 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 18.052603 |          18.025293 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  0.982425 |           1.126771 |
| components...                  |           |                    |
| * Enabled addons:              |  0.002700 |           0.003140 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.065023 |           0.066638 |
| configured to use "minikube"   |           |                    |
|                                |  6.382059 |           0.004804 |
+--------------------------------+-----------+--------------------+

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 29, 2020

k8s-ci-robot requested review from afbjorklund and priyawadhwa July 29, 2020 20:41

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2020

medyagh changed the title ~~advice user when they allocate too much memory~~ advice user when allocate more than 80% of their memory Jul 29, 2020

sharifelgamal reviewed Jul 29, 2020

View reviewed changes

cmd/minikube/cmd/start.go Show resolved Hide resolved

medyagh changed the title ~~advice user when allocate more than 80% of their memory~~ wip: advice user when allocate more than 80% of their memory Jul 30, 2020

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2020

medyagh force-pushed the max_memory branch from 25e6386 to 9cdb21a Compare August 3, 2020 21:41

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2020

medyagh changed the title ~~wip: advice user when allocate more than 80% of their memory~~ advice user when allocate more than 80% of their memory Aug 3, 2020

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2020

medyagh requested a review from sharifelgamal August 3, 2020 21:47

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 3, 2020

sharifelgamal reviewed Aug 3, 2020

View reviewed changes

pkg/minikube/machine/info.go Show resolved Hide resolved

pkg/minikube/machine/info.go Outdated Show resolved Hide resolved

pkg/minikube/machine/info.go Outdated Show resolved Hide resolved

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

sharifelgamal approved these changes Aug 4, 2020

View reviewed changes

medyagh added 4 commits August 4, 2020 13:26

advice user when they allocate too much memory

71394c4

update comments

e59a026

bring back check for dry run

d782f80

use cached hostinfo instead

b71a7dc

medyagh added 3 commits August 4, 2020 13:26

addres review comments

e87400d

fill up cpu memory if config is missing

e783af2

address review comments

98c2157

medyagh force-pushed the max_memory branch from d710082 to 98c2157 Compare August 4, 2020 20:26

sharifelgamal merged commit 8f1f74c into kubernetes:master Aug 4, 2020

medyagh mentioned this pull request Aug 11, 2020

improve error handling for validating memory limits #8959

Merged

medyagh deleted the max_memory branch March 2, 2021 21:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

advice user when allocate more than 80% of their memory #8877

advice user when allocate more than 80% of their memory #8877

medyagh commented Jul 29, 2020 •

edited

Loading

k8s-ci-robot commented Jul 29, 2020

TravisBuddy commented Aug 3, 2020

medyagh commented Aug 3, 2020

minikube-pr-bot commented Aug 3, 2020

minikube-pr-bot commented Aug 3, 2020

minikube-pr-bot commented Aug 4, 2020

medyagh commented Aug 4, 2020

minikube-pr-bot commented Aug 4, 2020

advice user when allocate more than 80% of their memory #8877

advice user when allocate more than 80% of their memory #8877

Conversation

medyagh commented Jul 29, 2020 • edited Loading

before this PR

after this PR on a macbook with 16 GB ram

Don't allow 17GB

Advice more than 80% allocation.

k8s-ci-robot commented Jul 29, 2020

TravisBuddy commented Aug 3, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: f35a20c0-d5d2-11ea-8ca9-c37e1b84d109

medyagh commented Aug 3, 2020

minikube-pr-bot commented Aug 3, 2020

minikube-pr-bot commented Aug 3, 2020

minikube-pr-bot commented Aug 4, 2020

medyagh commented Aug 4, 2020

minikube-pr-bot commented Aug 4, 2020

medyagh commented Jul 29, 2020 •

edited

Loading