Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Calico CNI (--cni=calico) #8571

Merged
merged 3 commits into from
Jul 17, 2020

Conversation

tstromberg
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 26, 2020
@tstromberg tstromberg requested a review from medyagh June 26, 2020 18:23
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 26, 2020
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2020
@medyagh
Copy link
Member

medyagh commented Jun 26, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 26, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 30, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [63.68418766800001 61.883687603 62.97726667399999]
Average time for minikube: 62.848380648333325

Times for Minikube (PR 8571): [61.546048448 63.98907366299999 62.610062204]
Average time for Minikube (PR 8571): 62.71506143833333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8571) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0 on Debian   |  0.053044 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.017057 |           0.018650 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003315 |           0.003326 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.842788 |          40.657424 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.459777 |                    |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.210272 |           1.521249 |
| components...                  |           |                    |
| * Enabled addons:              |  0.192135 |           0.139145 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066437 |           0.076583 |
| configured to use "minikube"   |           |                    |
|                                |  0.003555 |          20.243354 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [24.930641493 25.129204291999997 25.564694421000002]
Average time for minikube: 25.208180068666664

Times for Minikube (PR 8571): [25.169966723 25.062850113000003 25.518365958]
Average time for Minikube (PR 8571): 25.250394264666667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8571) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0 on Debian   |  0.066022 |                    |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.002531 |           0.002770 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.055361 |           0.057221 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  7.491253 |           7.523419 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 16.462025 |          16.606671 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.952058 |           0.798627 |
| components...                  |           |                    |
| * Enabled addons:              |  0.107164 |           0.128399 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.066920 |           0.062014 |
| configured to use "minikube"   |           |                    |
|                                |  0.004845 |           0.068185 |
+--------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [63.01320328699999 64.822838059 61.123147332]
Average time for minikube: 62.986396226000004

Times for Minikube (PR 8571): [61.437376982 64.367426268 63.049074191]
Average time for Minikube (PR 8571): 62.951292480333336

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8571) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0 on Debian   |  0.056007 |           0.052747 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.017101 |           0.017128 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.005247 |           0.003148 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.611248 |          39.639110 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.3 | 20.486590 |          21.671947 |
| on Docker 19.03.12 ...         |           |                    |
| * Verifying Kubernetes         |  1.637313 |           1.415439 |
| components...                  |           |                    |
| * Enabled addons:              |  0.092360 |           0.075790 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.077457 |           0.071406 |
| configured to use "minikube"   |           |                    |
|                                |  0.003075 |           0.004577 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.462588471 25.496832547 26.391546642]
Average time for minikube: 26.450322553333336

Times for Minikube (PR 8571): [26.714129266999993 25.744227404 26.697204313999997]
Average time for Minikube (PR 8571): 26.385186995

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8571) |
+--------------------------------+-----------+--------------------+
| * minikube v1.12.0 on Debian   |  0.068709 |           0.067444 |
|                           9.11 |           |                    |
| * Using the docker driver      |  0.002709 |           0.002727 |
| based on existing profile      |           |                    |
| * Starting control plane node  |  0.058146 |           0.057837 |
| minikube in cluster minikube   |           |                    |
| * Creating docker container    |  7.615921 |           7.515839 |
| (CPUs=2, Memory=3700MB) ...    |           |                    |
| * Preparing Kubernetes v1.18.3 | 17.734016 |          17.783430 |
| on Docker 19.03.2 ...          |           |                    |
| * Verifying Kubernetes         |  0.816432 |           0.767708 |
| components...                  |           |                    |
| * Enabled addons:              |  0.089188 |           0.117740 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.061701 |           0.067356 |
| configured to use "minikube"   |           |                    |
|                                |  0.003501 |           0.005105 |
+--------------------------------+-----------+--------------------+

@tstromberg
Copy link
Contributor Author

/ok-to-test

@tstromberg tstromberg merged commit efa7f61 into kubernetes:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants