Do not output usage hint when shell=none. #8531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
cncf-cla: no
|
Welcome @jtzwu! |
|
Hi @jtzwu. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jtzwu The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can one of the admins verify this patch? |
Travis tests have failedHey @jtzwu, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 45c3c2f0-b506-11ea-aae7-0b05fcc524af |
there is no clear way to expect how a usage hint will be interpretted.
k8s-ci-robot
added
cncf-cla: yes
Travis tests have failedHey @jtzwu, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: 1ace2780-b50a-11ea-aae7-0b05fcc524af |
Travis tests have failedHey @jtzwu, 1st Buildmake testTravisBuddy Request Identifier: 431954b0-b50c-11ea-aae7-0b05fcc524af |
medyagh
requested changes
Jun 23, 2020
tstromberg
approved these changes
Jun 23, 2020
|
Thank you! |
|
This is for the special hack of See a02541d Basically a text-based output, key=value. However, I don't seem to get any usage hint with v1.11.0 either ? EDIT: broke it in ae2ceee @@ -114,7 +114,10 @@ var shellConfigMap = map[string]shellData{
"\n",
"=",
func(s ...interface{}) string {
- return ""
+ return fmt.Sprintf(`
+# %s
+# eval $(%s)
+`, s...)
},
},
}
|
|
For normal shells, the $SHELL variable will actually be the full path to the shell. Like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no shell, there is no clear way to expect how a usage hint will be interpretted.