Fix host network interface for VBox

[11janci]

Fixes #8456

The regex selecting the interface was greedy - if another interface was printed after the one we're looking for, it would skip everything up to the IPAddress of the last interface in the list.
Also made more robust for matching the interface names (to prevent mismatches when multiple interfaces are named some_if, some_if #2, some_if #3 etc.)

[k8s-ci-robot]

Hi @11janci. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[codecov-commenter]

Codecov Report

Merging #8475 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #8475      +/-   ##
==========================================
- Coverage   34.05%   34.05%   -0.01%     
==========================================
  Files         153      153              
  Lines        9840     9841       +1     
==========================================
  Hits         3351     3351              
- Misses       6086     6087       +1     
  Partials      403      403              

Impacted Files	Coverage Δ
pkg/minikube/cluster/ip.go	0.00% <0.00%> (ø)

[11janci]

/assign @afbjorklund

[prasadkatti]

/ok-to-test

[medyagh]

/ok-to-test

[minikube-pr-bot]

kvm2 Driver
docker Driver

[11janci]

/test all

[k8s-ci-robot]

@11janci: No jobs can be run with /test all.
The following commands are available to trigger jobs:

• /test pull-minikube-platform-tests

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[11janci]

/test pull-minikube-platform-tests

[11janci]

can somebody pls help with the tests? the failures are unrelated, plus it seems it got stuck and I'm not able to rerun..

[k8s-ci-robot]

@11janci: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-minikube-platform-tests	bf59d39	link	/test pull-minikube-platform-tests

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[medyagh]

@11janci the test failures are flakes unrelated to this PR

[afbjorklund]

The regex selecting the interface was greedy - if another interface was printed after the one we're looking for, it would skip everything up to the IPAddress of the last interface in the list.
Also made more robust for matching the interface names (to prevent mismatches when multiple interfaces are named some_if, some_if #2, some_if #3 etc.)

Nice find! Not the bug that I was expecting, will give it a try locally to see that it fixes the issue

[afbjorklund]

Much happier:

$ more /etc/hosts 
127.0.0.1       localhost
127.0.1.1       minikube
192.168.99.1    host.minikube.internal
$ ping host.minikube.internal
PING host.minikube.internal (192.168.99.1): 56 data bytes
64 bytes from 192.168.99.1: seq=0 ttl=64 time=0.153 ms
64 bytes from 192.168.99.1: seq=1 ttl=64 time=0.176 ms
64 bytes from 192.168.99.1: seq=2 ttl=64 time=0.231 ms
^C
--- host.minikube.internal ping statistics ---
3 packets transmitted, 3 packets received, 0% packet loss
round-trip min/avg/max = 0.153/0.186/0.231 ms

[afbjorklund]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 11janci, afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afbjorklund]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment