Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option --all to stop all clusters #8285

Merged
merged 1 commit into from
Jun 9, 2020

Conversation

kadern0
Copy link
Contributor

@kadern0 kadern0 commented May 27, 2020

Resolves #8237

Signed-off-by: kadern0 kaderno@gmail.com

Example of the PR working:

./out/minikube start --profile=cluster1
πŸ˜„  [cluster1] minikube v1.10.1 on Ubuntu 20.04
✨  Using the docker driver based on existing profile
πŸ‘  Starting control plane node cluster1 in cluster cluster1
πŸ”„  Restarting existing docker container for "cluster1" ...
🐳  Preparing Kubernetes v1.18.2 on Docker 19.03.2 ...
    β–ͺ kubeadm.pod-network-cidr=10.244.0.0/16
πŸ”Ž  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
πŸ„  Done! kubectl is now configured to use "cluster1"

 ./out/minikube start --profile=cluster2
πŸ˜„  [cluster2] minikube v1.10.1 on Ubuntu 20.04
✨  Automatically selected the docker driver
πŸ‘  Starting control plane node cluster2 in cluster cluster2
πŸ”₯  Creating docker container (CPUs=2, Memory=3900MB) ...
🐳  Preparing Kubernetes v1.18.2 on Docker 19.03.2 ...
    β–ͺ kubeadm.pod-network-cidr=10.244.0.0/16
πŸ”Ž  Verifying Kubernetes components...
🌟  Enabled addons: default-storageclass, storage-provisioner
πŸ„  Done! kubectl is now configured to use "cluster2"

 ./out/minikube stop --all
βœ‹  Stopping "cluster1" in docker ...
πŸ›‘  Powering off "cluster1" via SSH ...
πŸ›‘  Node "cluster1" stopped.
βœ‹  Stopping "cluster2" in docker ...
πŸ›‘  Powering off "cluster2" via SSH ...
πŸ›‘  Node "cluster2" stopped.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label May 27, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @kadern0. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kadern0
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2020

Codecov Report

Merging #8285 into master will decrease coverage by 0.24%.
The diff coverage is 10.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8285      +/-   ##
==========================================
- Coverage   34.35%   34.11%   -0.25%     
==========================================
  Files         147      153       +6     
  Lines        9456     9823     +367     
==========================================
+ Hits         3249     3351     +102     
- Misses       5808     6069     +261     
- Partials      399      403       +4     
Impacted Files Coverage Ξ”
cmd/minikube/cmd/stop.go 6.66% <10.71%> (+6.66%) ⬆️
pkg/minikube/perf/start.go 13.15% <0.00%> (-16.85%) ⬇️
pkg/minikube/driver/driver.go 58.87% <0.00%> (-1.13%) ⬇️
cmd/minikube/cmd/start.go 13.51% <0.00%> (-0.22%) ⬇️
pkg/minikube/machine/fix.go 38.31% <0.00%> (ΓΈ)
pkg/minikube/machine/start.go 62.67% <0.00%> (ΓΈ)
pkg/minikube/perf/result_manager.go 0.00% <0.00%> (ΓΈ)
pkg/minikube/perf/logs.go 76.92% <0.00%> (ΓΈ)
pkg/minikube/image/image.go 7.05% <0.00%> (ΓΈ)
pkg/minikube/perf/result.go 100.00% <0.00%> (ΓΈ)
... and 8 more

@prasadkatti
Copy link
Contributor

@kadern0 - you will need to amend the commit msg to not include β€œfixes ...” and then force push it to get rid of the invalid commit message label.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jun 7, 2020
@kadern0
Copy link
Contributor Author

kadern0 commented Jun 7, 2020

@prasadkatti I've updated the commit message although I thought it is a common practice to reference the issue within the commit.

@prasadkatti
Copy link
Contributor

prasadkatti commented Jun 7, 2020

@kadern0 - yeah, I thought so too. I am not sure why it is setup that way. I had this same issue on one of my PRs a while back. So I thought I would help.

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this PR. looks good, just a minior nit

cmd/minikube/cmd/stop.go Outdated Show resolved Hide resolved
Related to kubernetes#8237

Signed-off-by: kadern0 <kaderno@gmail.com>
@medyagh medyagh merged commit fa0812c into kubernetes:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a new flag stop --all
6 participants