Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multinode: delete worker volumes for docker driver #8216

Merged
merged 1 commit into from
May 20, 2020
Merged

multinode: delete worker volumes for docker driver #8216

merged 1 commit into from
May 20, 2020

Conversation

sharifelgamal
Copy link
Collaborator

Fixes #8215

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2020
@medyagh
Copy link
Member

medyagh commented May 19, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 19, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@codecov-commenter
Copy link

Codecov Report

Merging #8216 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8216      +/-   ##
==========================================
- Coverage   34.59%   34.58%   -0.02%     
==========================================
  Files         147      147              
  Lines        9381     9384       +3     
==========================================
  Hits         3245     3245              
- Misses       5739     5742       +3     
  Partials      397      397
Impacted Files Coverage Δ
cmd/minikube/cmd/delete.go 21.45% <0.00%> (-0.16%) ⬇️
cmd/minikube/cmd/start.go 15.07% <0.00%> (-0.03%) ⬇️
pkg/minikube/machine/delete.go 33.92% <ø> (ø)

medyagh
medyagh approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thank you

@medyagh medyagh changed the title delete worker node volumes for docker driver multinode: delete worker node volumes for docker driver May 20, 2020
@medyagh medyagh changed the title multinode: delete worker node volumes for docker driver multinode: delete worker volumes for docker driver May 20, 2020
@medyagh medyagh merged commit add572c into kubernetes:master May 20, 2020
@fmotrifork fmotrifork mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh approved these changes

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube delete does not delete volumes of worker nodes in multinode
5 participants
@sharifelgamal @k8s-ci-robot @medyagh @minikube-pr-bot @codecov-commenter