Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recreate existing control plane node correctly #8095

Merged
merged 14 commits into from
May 18, 2020
Merged

recreate existing control plane node correctly #8095

merged 14 commits into from
May 18, 2020

Conversation

sharifelgamal
Copy link
Collaborator

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 12, 2020
medyagh
medyagh reviewed May 12, 2020
View reviewed changes
cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2020
@codecov-io
Copy link

codecov-io commented May 12, 2020 •
edited
Loading

Codecov Report

Merging #8095 into master will decrease coverage by 0.04%.
The diff coverage is 4.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8095      +/-   ##
==========================================
- Coverage   35.27%   35.23%   -0.05%     
==========================================
  Files         146      146              
  Lines        9326     9338      +12     
==========================================
  Hits         3290     3290              
- Misses       5637     5648      +11     
- Partials      399      400       +1
Impacted Files Coverage Δ
cmd/minikube/cmd/start_flags.go 50.80% <2.32%> (-0.17%) ⬇️
cmd/minikube/cmd/start.go 15.10% <8.69%> (-0.30%) ⬇️

@medyagh
Copy link
Member

medyagh commented May 12, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 12, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [69.535415254 65.992006229 68.903489413]
Average time for minikube: 68.14363696533333

Times for Minikube (PR 8095): [66.319241134 68.91209890900001 67.453674557]
Average time for Minikube (PR 8095): 67.56167153333332

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.067271 |                    |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.025648 |           0.022992 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004295 |           0.003803 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.553153 |          41.349443 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 24.247090 |                    |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.567502 |           1.519015 |
| components...                  |           |                    |
| * Enabled addons:              |  0.576307 |           0.638787 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.098344 |           0.089014 |
| configured to use "minikube"   |           |                    |
|                                |  0.004027 |           0.062553 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.482409964000006 28.226812407 27.946469061]
Average time for minikube: 28.218563810666666

Times for Minikube (PR 8095): [27.935773168 27.694867291 29.483425647999997]
Average time for Minikube (PR 8095): 28.371355369

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.073704 |                    |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.003009 |           0.002950 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.063855 |           0.063861 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.355268 |           8.367624 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.153686 |                    |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.497688 |          18.744616 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.984334 |           0.909378 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.011762 |           0.003385 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.070613 |           0.068318 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004644 |           0.074455 |
+----------------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [66.591297753 65.725167883 65.001313039]
Average time for minikube: 65.77259289166666

Times for Minikube (PR 8095): [65.436160993 67.098303313 63.998538867]
Average time for Minikube (PR 8095): 65.51100105766668

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.057121 |           0.065398 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019013 |           0.020082 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003237 |           0.003741 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.836932 |          40.319703 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 22.617258 |          23.055964 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.365999 |           1.868658 |
| components...                  |           |                    |
| * Enabled addons:              |  0.778864 |           0.097013 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.089763 |           0.076231 |
| configured to use "minikube"   |           |                    |
|                                |  0.004405 |           0.004211 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.89110152 24.569541660999995 26.674835614000003]
Average time for minikube: 26.378492931666667

Times for Minikube (PR 8095): [26.261838757000003 26.760169932000004 26.301329862999996]
Average time for Minikube (PR 8095): 26.441112850666666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.066343 |           0.067009 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002372 |           0.002731 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.059473 |           0.059668 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.734383 |           7.622738 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.143807 |           0.120010 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.076428 |          17.270671 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.153435 |           1.173812 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.064966 |           0.051796 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.072550 |           0.068260 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004737 |           0.004417 |
+----------------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [74.411004411 68.568348507 67.58537921300001]
Average time for minikube: 70.18824404366667

Times for Minikube (PR 8095): [69.077650515 68.314160258 67.63487408399999]
Average time for Minikube (PR 8095): 68.34222828566665

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.067138 |           0.074546 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.026175 |           0.024742 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.020914 |           0.010655 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 43.129199 |          42.081764 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 24.514507 |          23.751091 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.484909 |           1.955748 |
| components...                  |           |                    |
| * Enabled addons:              |  0.844351 |           0.343325 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.096051 |           0.092578 |
| configured to use "minikube"   |           |                    |
|                                |  0.005001 |           0.007778 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.408388357 28.848647523999997 30.260970198000003]
Average time for minikube: 29.506002026333334

Times for Minikube (PR 8095): [29.473707028 29.752290984999995 30.72012596]
Average time for Minikube (PR 8095): 29.982041324333334

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.082522 |           0.084136 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.003683 |           0.003341 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.069711 |           0.067399 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.386878 |           8.366143 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.137576 |           0.134325 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 19.448472 |          20.043083 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.298195 |           1.007035 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.003394 |           0.196157 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.071622 |           0.074840 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003949 |           0.005582 |
+----------------------------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 14, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [68.881514415 67.12458178499999 67.109062416]
Average time for minikube: 67.705052872

Times for Minikube (PR 8095): [68.20154640100002 70.112610917 71.08609035399999]
Average time for Minikube (PR 8095): 69.80008255733334

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.071789 |           0.073257 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.022749 |           0.019425 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004498 |           0.004944 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.498907 |          42.016776 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 23.842756 |          25.456969 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.754394 |           1.616022 |
| components...                  |           |                    |
| * Enabled addons:              |  0.409896 |           0.507099 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.094182 |           0.095745 |
| configured to use "minikube"   |           |                    |
|                                |  0.005882 |           0.005186 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [29.720125148 28.274750794000006 27.255988743]
Average time for minikube: 28.416954895000003

Times for Minikube (PR 8095): [28.28602349 28.030205579 27.265880543]
Average time for Minikube (PR 8095): 27.860703204000004

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.081066 |           0.087974 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.003063 |           0.000271 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.063169 |           0.067160 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.357714 |           8.193394 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.133086 |           0.131470 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.665481 |          18.008302 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.030108 |           1.234639 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.005005 |           0.049858 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.071841 |           0.078415 |
| configured to use "minikube"           |           |                    |
|                                        |  0.006422 |           0.006313 |
+----------------------------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 15, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [67.34777223000002 70.68098768300001 65.229763715]
Average time for minikube: 67.75284120933334

Times for Minikube (PR 8095): [66.478574354 65.85620127299998 69.021789817]
Average time for Minikube (PR 8095): 67.11885514800001

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.071848 |           0.063788 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.026914 |           0.019855 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.004163 |           0.005399 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 43.110201 |          41.609429 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 22.161791 |          23.354470 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.922701 |           1.601225 |
| components...                  |           |                    |
| * Enabled addons:              |  0.334611 |           0.368213 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.115607 |           0.088148 |
| configured to use "minikube"   |           |                    |
|                                |  0.005005 |           0.003683 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.48631859 29.012145430999993 27.375971201]
Average time for minikube: 27.958145074

Times for Minikube (PR 8095): [30.127837593999995 28.316468821 27.8600282]
Average time for Minikube (PR 8095): 28.768111538333333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.085463 |           0.083061 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002962 |           0.000246 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.066298 |           0.063703 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.144302 |           8.248841 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.126059 |           0.137710 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.178022 |          18.585786 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.178759 |           1.567472 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.106736 |           0.003006 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.065660 |           0.070440 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003884 |           0.002577 |
+----------------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [65.779574899 67.96428741 66.64044645300001]
Average time for minikube: 66.79476958733333

Times for Minikube (PR 8095): [67.019043889 63.451699547000004 66.016308956]
Average time for Minikube (PR 8095): 65.49568413066667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.065966 |           0.063863 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.022105 |           0.018811 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003937 |           0.003469 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.417843 |          40.531079 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 24.027573 |          22.835207 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.805492 |           1.382317 |
| components...                  |           |                    |
| * Enabled addons:              |  0.353854 |           0.583277 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.093671 |           0.069842 |
| configured to use "minikube"   |           |                    |
|                                |  0.004328 |           0.003142 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.172535543 27.732767024 27.295132062000004]
Average time for minikube: 27.400144876333332

Times for Minikube (PR 8095): [28.223497952999995 28.013585932999998 27.764959619]
Average time for Minikube (PR 8095): 28.00068116833333

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.082150 |           0.086215 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002979 |           0.000227 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.065712 |           0.066961 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.981544 |           8.182188 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.132097 |           0.128311 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.093002 |          18.529439 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.903117 |           0.920433 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.065182 |           0.003070 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.070004 |           0.076387 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004358 |           0.000003 |
+----------------------------------------+-----------+--------------------+

@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [70.215036622 65.93633743199999 64.843721588]
Average time for minikube: 66.998365214

Times for Minikube (PR 8095): [68.31172455000001 67.872543143 64.86261133600001]
Average time for Minikube (PR 8095): 67.01562634300001

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.072729 |           0.065792 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.023635 |           0.023246 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008448 |           0.005222 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.865748 |          40.793395 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 22.640685 |          24.582321 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.487844 |           0.890792 |
| components...                  |           |                    |
| * Enabled addons:              |  0.819718 |           0.579291 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.075155 |           0.071647 |
| configured to use "minikube"   |           |                    |
|                                |  0.004403 |           0.003921 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.451221799000002 28.730348672999998 30.159584727000002]
Average time for minikube: 29.113718399666666

Times for Minikube (PR 8095): [28.955223833999998 29.247014618 28.488851979999996]
Average time for Minikube (PR 8095): 28.897030144000002

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.084455 |           0.083608 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002730 |           0.003570 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.065011 |           0.066218 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.301025 |           8.131255 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.129169 |           0.130408 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 19.409650 |          19.734681 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.965709 |           0.673099 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.084241 |           0.003146 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.067268 |           0.066157 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004459 |           0.004889 |
+----------------------------------------+-----------+--------------------+

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 15, 2020
@minikube-pr-bot
Copy link

kvm2 Driver
Times for minikube: [70.373788684 66.734084403 66.268253947]
Average time for minikube: 67.79204234466668

Times for Minikube (PR 8095): [71.35985364299998 64.531376803 65.002410662]
Average time for Minikube (PR 8095): 66.96454703600001

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 8095) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian   |  0.071192 |           0.064820 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.021957 |           0.022964 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.008703 |           0.003372 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.626284 |          41.565165 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.2 | 24.008651 |          23.353795 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.406916 |           1.699508 |
| components...                  |           |                    |
| * Enabled addons:              |  0.567430 |           0.172385 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.076633 |           0.077844 |
| configured to use "minikube"   |           |                    |
|                                |  0.004276 |           0.004693 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [28.427964765 29.292594314 29.064113129]
Average time for minikube: 28.92822406933333

Times for Minikube (PR 8095): [28.234661621 29.393777134000004 27.103730868000003]
Average time for Minikube (PR 8095): 28.244056541000003

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 8095) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.1 on Debian           |  0.082070 |           0.082796 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.003357 |           0.003100 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.063862 |           0.064700 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.296900 |           8.214532 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.2         |  0.136917 |           0.134087 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 19.221701 |          18.341834 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.943659 |           1.326810 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.105248 |           0.002996 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.071366 |           0.067638 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003145 |           0.005564 |
+----------------------------------------+-----------+--------------------+

@sharifelgamal
Copy link
Collaborator Author

sharifelgamal commented May 18, 2020 •
edited
Loading

Docker test failure is a known flake: #8014

@sharifelgamal sharifelgamal merged commit 2754bb6 into kubernetes:master May 18, 2020
@fmotrifork fmotrifork mentioned this pull request Jun 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medyagh medyagh medyagh requested changes

@blueelvis blueelvis Awaiting requested review from blueelvis

@RA489 RA489 Awaiting requested review from RA489

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sharifelgamal @k8s-ci-robot @codecov-io @medyagh @minikube-pr-bot