Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env variable to configure force-systemd #8010

Merged
merged 1 commit into from
May 5, 2020

Conversation

priyawadhwa
Copy link

@priyawadhwa priyawadhwa commented May 5, 2020

Also add an integration test for the env variable

Rel #6404

Also add an integration test for the env variable
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels May 5, 2020
@priyawadhwa priyawadhwa added this to the v1.10.0 milestone May 5, 2020
@priyawadhwa priyawadhwa requested a review from medyagh May 5, 2020 19:13
@minikube-pr-bot
Copy link

kvm2 Driver
docker Driver

Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, with required comment for integration tests failures

@kubernetes kubernetes deleted a comment from priyawadhwa May 5, 2020
@priyawadhwa
Copy link
Author

priyawadhwa commented May 5, 2020

Docker_Linux

TestFunctional/parallel/ComponentHealth - 0.16s
#8014
TestFunctional/parallel/ServiceCmd - 53.31s
#8013
TestStartStop/group/containerd - 238.64s
#7704
TestStartStop/group/embed-certs - 824.01s
#7921

Hyperkit

TestFunctional/parallel/TunnelCmd
#8015

Virtualbox_Linux

TestErrorSpam
#8011

@medyagh
Copy link
Member

medyagh commented May 5, 2020

@priyawadhwa

TestFunctional/parallel/ServiceCmd - 53.31s
#7765

that issue was closed this one's error is

functional_test.go:712: get failed: GET http://172.17.0.3:30602 giving up after 5 attempts
resp: <nil>

that closed issue appears to be a different error:

:Get http://127.0.0.1:10251/healthz: dial tcp 127.0.0.1:10251: connect: connection refused Error:}]}

I recommend creating a new issue for this


similiarly ont he component health test
there seems to be simmilar connection refused error

functional_test.go:307: unexpected status: False - item: {TypeMeta:{Kind:ComponentStatus APIVersion:v1} ObjectMeta:{Name:controller-manager GenerateName: Namespace: SelfLink:/api/v1/componentstatuses/controller-manager UID: ResourceVersion: Generation:0 CreationTimestamp:0001-01-01 00:00:00 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[]} Conditions:[{Type:Healthy Status:False Message:Get http://127.0.0.1:10252/healthz: dial tcp 127.0.0.1:10252: connect: connection refused Error:}]

@priyawadhwa
Copy link
Author

@medyagh thanks, opened those issues and updated my comment.

@priyawadhwa priyawadhwa merged commit a3e9967 into kubernetes:master May 5, 2020
@priyawadhwa priyawadhwa deleted the systemd-env branch May 5, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants