Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman: Get the gateway by inspecting container network #7962

Merged
merged 2 commits into from
May 4, 2020

Conversation

afbjorklund
Copy link
Collaborator

Closes #7951

@afbjorklund afbjorklund requested a review from medyagh May 1, 2020 13:03
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 1, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 1, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good just needs the comment to be deleted

@codecov-io
Copy link

Codecov Report

Merging #7962 into master will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7962      +/-   ##
==========================================
+ Coverage   35.71%   36.04%   +0.33%     
==========================================
  Files         149      144       -5     
  Lines        9408     9196     -212     
==========================================
- Hits         3360     3315      -45     
+ Misses       5644     5480     -164     
+ Partials      404      401       -3     
Impacted Files Coverage Δ
cmd/minikube/cmd/tunnel.go 5.26% <100.00%> (+0.13%) ⬆️
cmd/minikube/cmd/node_add.go 17.85% <0.00%> (-1.38%) ⬇️
cmd/minikube/cmd/start.go 15.61% <0.00%> (-0.12%) ⬇️
pkg/minikube/download/progressbar.go

@medyagh medyagh merged commit 6eeb929 into kubernetes:master May 4, 2020
@medyagh medyagh changed the title Get the gateway by inspecting container network podman: Get the gateway by inspecting container network May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube on podman driver: failed to start node: RoutableHostIPFromInside
5 participants