improve auto-select memory for multinode clusters #7928

sharifelgamal · 2020-04-28T17:12:40Z

This should fix all the OOM errors for multinode tests.

Should fix #7852

k8s-ci-robot · 2020-04-28T17:13:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cmd/minikube/cmd/node_add.go

cmd/minikube/cmd/start.go

cmd/minikube/cmd/start_flags.go

medyagh · 2020-04-28T19:36:09Z

/ok-to-test

minikube-pr-bot · 2020-04-28T19:38:49Z

kvm2 Driver
docker Driver

medyagh

looks good to me.
approved with Required Comments to point any test failure to an existing issue or create a new issue for any not mentioned failure.

sharifelgamal · 2020-04-28T23:01:40Z

The 3 Docker_Linux failures are known: TestStartStop/group/crio (#7808), TestStartStop/group/containerd (#7704), and TestStartStop/group/embed-certs (#7921)

minikube-pr-bot · 2020-04-29T00:22:03Z

kvm2 Driver
Times for minikube: [63.071306027999995 62.791660116 67.327666999]
Average time for minikube: 64.39687771433334

Times for Minikube (PR 7928): [67.208690622 68.566507617 64.593782886]
Average time for Minikube (PR 7928): 66.789660375

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7928) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on   |  0.073951 |           0.062472 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.024685 |           0.021075 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.028811 |           0.010697 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.302123 |          40.724825 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.007144 |          23.633424 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.380064 |           1.787632 |
| components...                  |           |                    |
| * Enabled addons:              |  0.478549 |           0.467780 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.097026 |           0.075037 |
| configured to use "minikube"   |           |                    |
|                                |  0.004526 |           0.006718 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.693062877 27.494514073 27.067443708]
Average time for minikube: 27.418340219333334

Times for Minikube (PR 7928): [25.442801833999997 25.890320165 26.674187583]
Average time for Minikube (PR 7928): 26.002436527333334

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7928) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on           |  0.077600 |           0.078668 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.002846 |           0.002862 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.061582 |           0.061240 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  8.013113 |           7.774036 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000202 |           0.000226 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 17.886662 |          16.576816 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  1.268273 |           1.430328 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.038595 |           0.002496 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.066683 |           0.069932 |
| configured to use "minikube"           |           |                    |
|                                        |  0.002785 |           0.005833 |
+----------------------------------------+-----------+--------------------+

minikube-pr-bot · 2020-04-29T01:12:12Z

kvm2 Driver
Times for minikube: [64.03654538199999 65.35194563999998 64.604647381]
Average time for minikube: 64.66437946766666

Times for Minikube (PR 7928): [63.942775034 63.679216493 64.816491196]
Average time for Minikube (PR 7928): 64.14616090766667

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7928) |
+--------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on   |  0.061273 |           0.062332 |
| Debian 9.11                    |           |                    |
| * Using the kvm2 driver based  |  0.021992 |           0.022101 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.013686 |           0.003544 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.428266 |          40.174286 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 21.904365 |          22.000747 |
| on Docker 19.03.8 ...          |           |                    |
| * Verifying Kubernetes         |  1.652805 |           1.271282 |
| components...                  |           |                    |
| * Enabled addons:              |  0.490443 |           0.532170 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.087399 |           0.074094 |
| configured to use "minikube"   |           |                    |
|                                |  0.004149 |           0.005604 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [27.081112491 27.848334497 27.524616638000005]
Average time for minikube: 27.484687875333332

Times for Minikube (PR 7928): [27.322596721 26.26879822 28.896340386]
Average time for Minikube (PR 7928): 27.495911775666666

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7928) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.10.0-beta.1 on           |  0.079663 |           0.076258 |
| Debian 9.11                            |           |                    |
| * Using the docker driver              |  0.003150 |           0.002479 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.061085 |           0.063434 |
| minikube in cluster minikube           |           |                    |
| * Creating docker container            |  7.869372 |           7.548665 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000233 |           0.000246 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 18.509533 |          18.169724 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Verifying Kubernetes                 |  0.786943 |           1.560067 |
| components...                          |           |                    |
| * Enabled addons:                      |  0.105429 |           0.002705 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.066058 |           0.067163 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003223 |           0.005171 |
+----------------------------------------+-----------+--------------------+

medyagh

looks good, thank you.

be smarter about allocating memory for multinode clusters

e61a18c

sharifelgamal requested review from medyagh and afbjorklund April 28, 2020 17:12

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2020

k8s-ci-robot requested review from blueelvis and priyawadhwa April 28, 2020 17:13

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020

lint

b116cd1

medyagh requested changes Apr 28, 2020

View reviewed changes

cmd/minikube/cmd/node_add.go Show resolved Hide resolved

cmd/minikube/cmd/start.go Show resolved Hide resolved

add unit tests

de5e493

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 28, 2020

medyagh reviewed Apr 28, 2020

View reviewed changes

cmd/minikube/cmd/start_flags.go Show resolved Hide resolved

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Apr 28, 2020

medyagh approved these changes Apr 28, 2020

View reviewed changes

medyagh changed the title ~~be smarter about allocating memory for multinode clusters~~ improve auto-select memory for multinode clusters Apr 28, 2020

debugging for multinode test

dc0ceee

don't run multinode tests in parallel

90cd6c3

medyagh approved these changes Apr 29, 2020

View reviewed changes

medyagh merged commit c739d3f into kubernetes:master Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve auto-select memory for multinode clusters #7928

improve auto-select memory for multinode clusters #7928

sharifelgamal commented Apr 28, 2020 •

edited

Loading

k8s-ci-robot commented Apr 28, 2020

medyagh commented Apr 28, 2020

minikube-pr-bot commented Apr 28, 2020

medyagh left a comment

sharifelgamal commented Apr 28, 2020 •

edited

Loading

minikube-pr-bot commented Apr 29, 2020

minikube-pr-bot commented Apr 29, 2020

medyagh left a comment

improve auto-select memory for multinode clusters #7928

improve auto-select memory for multinode clusters #7928

Conversation

sharifelgamal commented Apr 28, 2020 • edited Loading

k8s-ci-robot commented Apr 28, 2020

medyagh commented Apr 28, 2020

minikube-pr-bot commented Apr 28, 2020

medyagh left a comment

Choose a reason for hiding this comment

sharifelgamal commented Apr 28, 2020 • edited Loading

minikube-pr-bot commented Apr 29, 2020

minikube-pr-bot commented Apr 29, 2020

medyagh left a comment

Choose a reason for hiding this comment

sharifelgamal commented Apr 28, 2020 •

edited

Loading

sharifelgamal commented Apr 28, 2020 •

edited

Loading