Add master node/worker node type to `minikube status` #7586

govargo · 2020-04-10T13:56:36Z

What type of PR is this?

/kind ux

What this PR does / why we need it:

When minikube status is executed, the node name & component status are printed.
It don't have node type like master or worker.

This PR add node type(master/worker) to minikube status for user to know node clearly.

Which issue(s) this PR fixes:

Fixes #7475

Does this PR introduce a user-facing change?

Yes.
This PR fixes the minikube status command output(node type).

Before this PR

$ out/minikube status
minikube
host: Running
kubelet: Running
apiserver: Running
kubeconfig: Configured

minikube-m02
host: Running
kubelet: Running

After this PR

$ out/minikube status
master node: minikube
host: Running
kubelet: Running
apiserver: Running
kubeconfig: Configured

worker node: minikube-m02
host: Running
kubelet: Running

Added node type master node and worker node.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

k8s-ci-robot · 2020-04-10T13:56:45Z

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-04-10T13:57:02Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign sharifelgamal
You can assign the PR to them by writing /assign @sharifelgamal in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-bot · 2020-04-10T13:57:02Z

Can one of the admins verify this patch?

govargo · 2020-04-10T13:57:25Z

/assign @sharifelgamal

medyagh · 2020-04-10T22:16:24Z

/ok-to-test

minikube-pr-bot · 2020-04-10T22:25:57Z

kvm2 Driver
docker Driver

sharifelgamal · 2020-04-11T00:26:30Z

Could you change it to have type: attribute instead of appending it to the node name?

For example,

$ out/minikube status
minikube
type: Control Plane
host: Running
kubelet: Running
apiserver: Running
kubeconfig: Configured

minikube-m02
type: Worker
host: Running
kubelet: Running

govargo · 2020-04-11T09:40:51Z

I updated to add type to each node.

govargo · 2020-04-11T09:41:58Z

I noticed there is the multi node tutorial docs after I opened this PR.
And I added minikube status output example to it.

minikube-pr-bot · 2020-04-11T09:55:35Z

kvm2 Driver
Times for minikube: [65.486760528 63.068115647 64.057181136]
Average time for minikube: 64.20401910366667

Times for Minikube (PR 7586): [60.630296565 64.62627673899999 61.138140944]
Average time for Minikube (PR 7586): 62.13157141599999

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7586) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.057007 |           0.054364 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.017569 |           0.018366 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.003140 |           0.002799 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 41.956894 |          40.178798 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 20.326404 |          19.951991 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.760048 |           1.847329 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079687 |           0.073663 |
| configured to use "minikube"   |           |                    |
|                                |  0.003270 |           0.004261 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [26.210655147 25.178506902 25.693017427]
Average time for minikube: 25.69405982533333

Times for Minikube (PR 7586): [35.594420821 32.970830936 45.955961341]
Average time for Minikube (PR 7586): 38.17373769933334

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7586) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.071102 |           0.067283 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002025 |           0.002205 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.000489 |           0.000124 |
| minikube in cluster minikube           |           |                    |
| * Pulling base image ...               |  0.146886 |           0.150649 |
| * Creating Kubernetes in               |  7.281042 |           8.406201 |
| docker container with (CPUs=2)         |           |                    |
| (4 available), Memory=3700MB           |           |                    |
| (15043MB available) ...                |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000161 |           0.097598 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.870674 |          24.118811 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.257055 |           5.257779 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060312 |           0.069543 |
| configured to use "minikube"           |           |                    |
|                                        |  0.004314 |           0.003544 |
+----------------------------------------+-----------+--------------------+

codecov-io · 2020-04-13T06:54:05Z

Codecov Report

Merging #7586 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7586   +/-   ##
=======================================
  Coverage   36.49%   36.49%           
=======================================
  Files         147      147           
  Lines        9139     9139           
=======================================
  Hits         3335     3335           
  Misses       5416     5416           
  Partials      388      388

Impacted Files	Coverage Δ
cmd/minikube/cmd/status.go	`21.18% <ø> (ø)`

sharifelgamal · 2020-04-13T16:33:52Z

site/content/en/docs/tutorials/multi_node.md

@@ -42,6 +43,21 @@ multinode-demo       Ready    master   9m58s   v1.18.0
 multinode-demo-m02   Ready    <none>   9m5s    v1.18.0
 ```

+```


Add a note here:

You can also check the status of your nodes:

Added the NOTE.

minikube-pr-bot · 2020-04-14T03:06:21Z

kvm2 Driver
Times for minikube: [64.468924122 62.823430949 65.970996493]
Average time for minikube: 64.421117188

Times for Minikube (PR 7586): [63.288898895 61.998257601000006 60.506507842999994]
Average time for Minikube (PR 7586): 61.93122144633333

Averages Time Per Log

+--------------------------------+-----------+--------------------+
|              LOG               | MINIKUBE  | MINIKUBE (PR 7586) |
+--------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian    |  0.055102 |           0.056091 |
|                           9.11 |           |                    |
| * Using the kvm2 driver based  |  0.019845 |           0.019374 |
| on existing profile            |           |                    |
| * Starting control plane node  |  0.015585 |           0.004705 |
| minikube in cluster minikube   |           |                    |
| * Creating kvm2 VM (CPUs=2,    | 40.428127 |          40.273569 |
| Memory=3700MB, Disk=20000MB)   |           |                    |
| ...                            |           |                    |
| * Preparing Kubernetes v1.18.0 | 22.019570 |          19.727939 |
| on Docker 19.03.8 ...          |           |                    |
| * Enabling addons:             |  1.794941 |           1.778082 |
| default-storageclass,          |           |                    |
| storage-provisioner            |           |                    |
| * Done! kubectl is now         |  0.079588 |           0.067227 |
| configured to use "minikube"   |           |                    |
|                                |  0.008360 |           0.004235 |
+--------------------------------+-----------+--------------------+

docker Driver
Times for minikube: [25.597429407 25.900885767999995 25.803364665]
Average time for minikube: 25.76722661333333

Times for Minikube (PR 7586): [26.658757137000002 25.169288617 24.032754563000005]
Average time for Minikube (PR 7586): 25.286933439

Averages Time Per Log

+----------------------------------------+-----------+--------------------+
|                  LOG                   | MINIKUBE  | MINIKUBE (PR 7586) |
+----------------------------------------+-----------+--------------------+
| * minikube v1.9.2 on Debian            |  0.070244 |           0.071952 |
|                                   9.11 |           |                    |
| * Using the docker driver              |  0.002480 |           0.002151 |
| based on existing profile              |           |                    |
| * Starting control plane node          |  0.000114 |           0.000119 |
| minikube in cluster minikube           |           |                    |
| * Pulling base image ...               |  0.057068 |           0.054093 |
| * Creating docker container            |  7.254650 |           7.430912 |
| (CPUs=2, Memory=3700MB) ...            |           |                    |
| * Preparing Kubernetes v1.18.0         |  0.000157 |           0.000164 |
| on Docker 19.03.2 ...                  |           |                    |
|   -                                    | 16.878574 |          16.279409 |
| kubeadm.pod-network-cidr=10.244.0.0/16 |           |                    |
| * Enabling addons:                     |  1.439811 |           1.378675 |
| default-storageclass,                  |           |                    |
| storage-provisioner                    |           |                    |
| * Done! kubectl is now                 |  0.060707 |           0.062676 |
| configured to use "minikube"           |           |                    |
|                                        |  0.003421 |           0.006781 |
+----------------------------------------+-----------+--------------------+

k8s-ci-robot added kind/ux cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 10, 2020

k8s-ci-robot requested review from josedonizetti and medyagh April 10, 2020 13:57

k8s-ci-robot assigned sharifelgamal Apr 10, 2020

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 10, 2020

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2020

sharifelgamal reviewed Apr 13, 2020

View reviewed changes

govargo added 4 commits April 14, 2020 11:53

add master node/worker node section to minikube status

4733332

Add node type to each node in minikube status

29f1144

Update minikube status output example to multi node tutorial

83d6d59

Add NOTE about status to multi node tutorial

9036230

sharifelgamal approved these changes Apr 15, 2020

View reviewed changes

sharifelgamal merged commit 1554d8e into kubernetes:master Apr 15, 2020

govargo deleted the feature/add-status-node-section branch February 13, 2021 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add master node/worker node type to `minikube status` #7586

Add master node/worker node type to `minikube status` #7586

govargo commented Apr 10, 2020

k8s-ci-robot commented Apr 10, 2020

k8s-ci-robot commented Apr 10, 2020

minikube-bot commented Apr 10, 2020

govargo commented Apr 10, 2020

medyagh commented Apr 10, 2020

minikube-pr-bot commented Apr 10, 2020

sharifelgamal commented Apr 11, 2020

govargo commented Apr 11, 2020

govargo commented Apr 11, 2020

minikube-pr-bot commented Apr 11, 2020

codecov-io commented Apr 13, 2020

sharifelgamal Apr 13, 2020

govargo Apr 14, 2020 •

edited

Loading

minikube-pr-bot commented Apr 14, 2020

Add master node/worker node type to minikube status #7586

Add master node/worker node type to minikube status #7586

Conversation

govargo commented Apr 10, 2020

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Apr 10, 2020

k8s-ci-robot commented Apr 10, 2020

minikube-bot commented Apr 10, 2020

govargo commented Apr 10, 2020

medyagh commented Apr 10, 2020

minikube-pr-bot commented Apr 10, 2020

sharifelgamal commented Apr 11, 2020

govargo commented Apr 11, 2020

govargo commented Apr 11, 2020

minikube-pr-bot commented Apr 11, 2020

codecov-io commented Apr 13, 2020

Codecov Report

sharifelgamal Apr 13, 2020

Choose a reason for hiding this comment

govargo Apr 14, 2020 • edited Loading

Choose a reason for hiding this comment

minikube-pr-bot commented Apr 14, 2020

Add master node/worker node type to `minikube status` #7586

Add master node/worker node type to `minikube status` #7586

govargo Apr 14, 2020 •

edited

Loading