Fix minikube delete output nodename missing with KIC driver

[govargo]

What type of PR is this?

/kind bug
/kind cleanup

What this PR does / why we need it:

When minikube delete with KIC driver is executed, the node name isn't outputed although other driver(virtualbox, hyperkit) does.

This PR fix that behavior. I added the deleted node name information.

Which issue(s) this PR fixes:

Fixes #7517

Does this PR introduce a user-facing change?

Yes.
This PR fixes the minikube delete command output(nodename).

Before this PR

(single node)

$ LC_ALL=en out/minikube start --driver docker
😄  minikube v1.9.2 on Darwin 10.14.5
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=4000MB (8204MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

$ LC_ALL=en out/minikube delete
🔥  Removing /Users/XXX/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.

(multi node)

$ LC_ALL=en out/minikube start --driver docker -n 2
😄  minikube v1.9.2 on Darwin 10.14.5
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=4000MB (8204MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner

👍  Starting node minikube-m02 in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=4000MB (8204MB available) ...
🌐  Found network options:
    ▪ NO_PROXY=172.17.0.3
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
🏄  Done! kubectl is now configured to use "minikube"

$ LC_ALL=en out/minikube delete
🔥  Deleting "minikube-m02" in docker ...
🔥  Removing /Users/XXX/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.

After this PR

(single node)

$ LC_ALL=en out/minikube start --driver docker
😄  minikube v1.9.2 on Darwin 10.14.5
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=4000MB (8204MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner
🏄  Done! kubectl is now configured to use "minikube"

$ LC_ALL=en out/minikube delete
🔥  Deleting "minikube" in docker ...
🔥  Removing /Users/XXX/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.

(multi node)

$ LC_ALL=en out/minikube start --driver docker -n 2
😄  minikube v1.9.2 on Darwin 10.14.5
✨  Using the docker driver based on user configuration
👍  Starting control plane node minikube in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=4000MB (8204MB available) ...
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
    ▪ kubeadm.pod-network-cidr=10.244.0.0/16
🌟  Enabling addons: default-storageclass, storage-provisioner

👍  Starting node minikube-m02 in cluster minikube
🚜  Pulling base image ...
🔥  Creating Kubernetes in docker container with (CPUs=2) (4 available), Memory=4000MB (8204MB available) ...
🌐  Found network options:
    ▪ NO_PROXY=172.17.0.3
🐳  Preparing Kubernetes v1.18.0 on Docker 19.03.2 ...
🏄  Done! kubectl is now configured to use "minikube"

$ LC_ALL=en out/minikube delete
🔥  Deleting "minikube" in docker ...
🔥  Deleting "minikube-m02" in docker ...
🔥  Removing /Users/XXX/.minikube/machines/minikube ...
💀  Removed all traces of the "minikube" cluster.

Added node name section in minikube delete.
🔥 Deleting "minikube" in docker ...

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

[k8s-ci-robot]

Hi @govargo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: govargo
To complete the pull request process, please assign tstromberg
You can assign the PR to them by writing /assign @tstromberg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tstromberg]

/ok-to-test

[minikube-bot]

Can one of the admins verify this patch?

[minikube-pr-bot]

Error: running mkcmp
2020/04/09 17:59:42 Executing run 1/3...
2020/04/09 17:59:42 Running: [/home/performance-monitor/minikube/out/minikube start]...
2020/04/09 17:59:42 Running: [/home/performance-monitor/minikube/out/minikube start]...
: exit status 1

[medyagh]

Thank you very much @govargo for this nice good quality PRs !

[medyagh]

virtualbox test fail https://storage.googleapis.com/minikube-builds/logs/7553/903fe74/VirtualBox_Linux.html#fail_TestStartStop%2fgroup%2fcrio

is not related to this PR it is a known issue #7541