Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If user doesn't specify driver, don't validate against existing cluster #7096

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

priyawadhwa
Copy link

@priyawadhwa priyawadhwa commented Mar 18, 2020

$ minikube start --driver docker
πŸ˜„  minikube v1.9.0-beta.1 on Darwin 10.14.6
✨  Using the docker driver based on user configuration
πŸ”₯  Creating Kubernetes in docker container with (CPUs=2) (8 available), Memory=1988MB (1988MB available) ...
🐳  Preparing Kubernetes v1.18.0-rc.1 on Docker 19.03.2 ...
    β–ͺ kubeadm.pod-network-cidr=10.244.0.0/16
    > kubectl.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubeadm.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubelet.sha256: 65 B / 65 B [--------------------------] 100.00% ? p/s 0s
    > kubectl: 41.99 MiB / 41.99 MiB [---------------] 100.00% 1.72 MiB p/s 25s
    > kubeadm: 37.97 MiB / 37.97 MiB [---------------] 100.00% 1.50 MiB p/s 26s
    > kubelet: 108.02 MiB / 108.02 MiB [-------------] 100.00% 1.99 MiB p/s 55s
πŸš€  Launching Kubernetes ... 
🌟  Enabling addons: default-storageclass, storage-provisioner
βŒ›  Waiting for cluster to come online ...
πŸ„  Done! kubectl is now configured to use "minikube"

❗  /usr/local/bin/kubectl is v1.16.1, which may be incompatible with Kubernetes v1.18.0-rc.1.
πŸ’‘  You can also use 'minikube kubectl -- get pods' to invoke a matching version

$ minikube start 
πŸ˜„  minikube v1.9.0-beta.1 on Darwin 10.14.6
✨  Using the docker driver based on existing profile
βŒ›  Reconfiguring existing host ...
πŸƒ  Using the running docker "minikube" container ...
🐳  Preparing Kubernetes v1.18.0-rc.1 on Docker 19.03.2 ...
    β–ͺ kubeadm.pod-network-cidr=10.244.0.0/16
πŸš€  Launching Kubernetes ... 
🌟  Enabling addons: default-storageclass, storage-provisioner
πŸ„  Done! kubectl is now configured to use "minikube"

❗  /usr/local/bin/kubectl is v1.16.1, which may be incompatible with Kubernetes v1.18.0-rc.1.
πŸ’‘  You can also use 'minikube kubectl -- get pods' to invoke a matching version

Should fix #7095

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: priyawadhwa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2020
@codecov-io
Copy link

Codecov Report

Merging #7096 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7096      +/-   ##
==========================================
- Coverage   37.20%   37.19%   -0.01%     
==========================================
  Files         146      146              
  Lines        9104     9106       +2     
==========================================
  Hits         3387     3387              
- Misses       5301     5303       +2     
  Partials      416      416              
Impacted Files Coverage Ξ”
cmd/minikube/cmd/start.go 37.69% <0.00%> (-0.13%) ⬇️

@tstromberg tstromberg merged commit 073e3af into kubernetes:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
4 participants