Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round suggested memory alloc by 100MB for VM's #6987

Merged
merged 4 commits into from
Mar 11, 2020

Conversation

tstromberg
Copy link
Contributor

Fixes #6964

There are now loads of tests, but here is a log from an example run:

I0310 16:00:45.581333 12309 start.go:870] Using suggested 6000MB memory alloc based on sys=32768MB, container=0MB

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Mar 10, 2020
@minikube-pr-bot
Copy link

Error: running mkcmp: exit status 1

@medyagh
Copy link
Member

medyagh commented Mar 10, 2020

/ok-to-test

@medyagh
Copy link
Member

medyagh commented Mar 10, 2020

Unit test:

ERROR: logging before flag.Parse: I0310 23:10:19.830429   11737 translate.go:92] Setting Language to en-US ...
E0310 23:10:23.501919   11737 out.go:95] [unset errFile]: ! Not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E0310 23:10:23.502235   11737 out.go:95] [unset errFile]: X Invalid size passed in argument: invalid size: ''

@minikube-pr-bot
Copy link

All Times minikube: [ 64.239642 61.497723 66.504116]
All Times Minikube (PR 6987): [ 64.386485 65.495149 66.055794]

Average minikube: 64.080494
Average Minikube (PR 6987): 65.312476

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6987) |
+----------------------+-----------+--------------------+
| minikube v           |  0.221953 |           0.324666 |
| Creating kvm2        | 40.689888 |          39.762151 |
| Preparing Kubernetes |  0.785908 |           0.778984 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.247547 |          21.375057 |
| Waiting for cluster  |  0.059502 |           0.055201 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Mar 11, 2020

@tstromberg
unit test

ERROR: logging before flag.Parse: I0310 23:49:02.571270   11360 translate.go:92] Setting Language to en-US ...
E0310 23:49:08.942929   11360 out.go:95] [unset errFile]: ! Not passing HTTP_PROXY=127.0.0.1:3128 to docker env.
E0310 23:49:08.943451   11360 out.go:95] [unset errFile]: X Invalid size passed in argument: invalid size: ''
FAIL	k8s.io/minikube/cmd/minikube/cmd	6.456s

@tstromberg
Copy link
Contributor Author

I removed a line I didn't think was required, but was. Made it so that CalculateSizeInMB returns an exit rather than errors to make it debuggable.

@minikube-pr-bot
Copy link

All Times Minikube (PR 6987): [ 66.226323 65.429023 66.518674]
All Times minikube: [ 63.850632 65.871421 65.708414]

Average minikube: 65.143489
Average Minikube (PR 6987): 66.058007

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 6987) |
+----------------------+-----------+--------------------+
| minikube v           |  0.224629 |           0.219474 |
| Creating kvm2        | 41.587406 |          41.038224 |
| Preparing Kubernetes |  0.801696 |           0.781703 |
| Pulling images       |           |                    |
| Launching Kubernetes | 19.589378 |          21.179187 |
| Waiting for cluster  |  0.062582 |           0.067540 |
+----------------------+-----------+--------------------+

@medyagh
Copy link
Member

medyagh commented Mar 11, 2020

The TestFunctional/parallel/CertSync on Docker driver is a new flake:

#6993

@medyagh
Copy link
Member

medyagh commented Mar 11, 2020

TestStartStop/group/crio is a failing test not related to this PR:
#6996

@medyagh
Copy link
Member

medyagh commented Mar 11, 2020

@tstromberg looks good to me, feel free to merge whenever you are ready.

@medyagh medyagh merged commit 12c12c4 into kubernetes:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyperv: The memory value assigned ('4077' MB) is not properly aligned.
4 participants