Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Docker to 19.03.6 #6618

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

afbjorklund
Copy link
Collaborator

Including:

runc v1.0.0-rc10

containerd v1.2.12

https://docs.docker.com/engine/release-notes/#19036

    runc v1.0.0-rc10

    containerd v1.2.12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2020
Copy link
Member

@medyagh medyagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance could have same version in Dockerfile for kicbase image?

@afbjorklund
Copy link
Collaborator Author

You seem to be installing docker.io, so you should get the latest available ?

FROM ubuntu:19.10
RUN apt-get update && apt-get install -y --no-install-recommends docker.io

https://packages.ubuntu.com/eoan/docker.io (currently 19.03.2-0ubuntu1)

So still the same major version (from last year), but a few minor versions behind.

@codecov-io
Copy link

Codecov Report

Merging #6618 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6618      +/-   ##
==========================================
- Coverage   37.56%   37.51%   -0.06%     
==========================================
  Files         138      138              
  Lines        8779     8792      +13     
==========================================
  Hits         3298     3298              
- Misses       5065     5080      +15     
+ Partials      416      414       -2
Impacted Files Coverage Δ
pkg/minikube/driver/driver.go 57.5% <0%> (-3.03%) ⬇️
cmd/minikube/cmd/start.go 22.44% <0%> (-0.04%) ⬇️
cmd/minikube/cmd/docker-env.go 39.83% <0%> (ø) ⬆️
pkg/minikube/machine/client.go 43.84% <0%> (ø) ⬆️
pkg/addons/kubectl.go 56.52% <0%> (ø) ⬆️
pkg/minikube/command/kic_runner.go 0% <0%> (ø) ⬆️
pkg/minikube/driver/driver_linux.go 0% <0%> (ø) ⬆️

@afbjorklund
Copy link
Collaborator Author

@medyagh : supposedly you could switch repositories, from ubuntu to docker ?

https://docs.docker.com/install/linux/docker-ce/ubuntu/

sudo add-apt-repository \
   "deb [arch=amd64] https://download.docker.com/linux/ubuntu \
   $(lsb_release -cs) \
   stable"

That will get you the newer versions:

containerd.io_1.2.12-1_amd64.deb
docker-ce-cli_19.03.6~3-0~ubuntu-eoan_amd64.deb
docker-ce_19.03.6~3-0~ubuntu-eoan_amd64.deb

@medyagh medyagh merged commit c977faf into kubernetes:master Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants