Remove depreacted annotation storageclass.beta.kubernetes.io

[olivierlemasle]

Replaces storageclass.beta.kubernetes.io/is-default-class is replaced by storageclass.kubernetes.io/is-default-class.

storageclass.beta.kubernetes.io/is-default-class is deprecated since k8s 1.6 (cf kubernetes/kubernetes#40088) and Minikube supports k8s versions >= 1.11.

Fixes #5953

[k8s-ci-robot]

Hi @olivierlemasle. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[minikube-bot]

Can one of the admins verify this patch?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olivierlemasle
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-io]

Codecov Report

Merging #5954 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #5954   +/-   ##
=======================================
  Coverage   36.09%   36.09%           
=======================================
  Files         110      110           
  Lines        8208     8208           
=======================================
  Hits         2963     2963           
  Misses       4854     4854           
  Partials      391      391

Impacted Files	Coverage Δ
pkg/minikube/storageclass/storageclass.go	95.12% <100%> (ø)	⬆️

[tstromberg]

/ok-to-test

[tstromberg]

Thank you for your PR!

[RA489]

/ok-to-test

[olivierlemasle]

/retest

[priyawadhwa]

/ok-to-test

[priyawadhwa]

I think the integration test errors are all flakes:

HyperV

--- FAIL: TestStartStop (1694.95s)
    --- FAIL: TestStartStop/group (0.00s)
        --- FAIL: TestStartStop/group/crio (1183.30s)

* Error: [IP_NOT_FOUND] getting kubeadm bootstrapper: command runner: getting ssh client for bootstrapper: Error creating new ssh host from driver: Error getting ssh host name for driver: IP not found

Hyperkit (#4206)

FAIL: TestDockerFlags (279.13s)

--- FAIL: TestStartStop (569.65s)
    --- FAIL: TestStartStop/group (0.00s)
        --- FAIL: TestStartStop/group/docker (271.63s)
        --- FAIL: TestStartStop/group/cni (220.18s)
        --- FAIL: TestStartStop/group/crio (220.31s)
        --- FAIL: TestStartStop/group/containerd (248.43s)

Unable to start VM: create: Error creating machine: Error in driver during machine creation: IP address never found in dhcp leases file Temporary error: could not find an IP address for 2:6a:4d:9f:75:56

KVM

--- FAIL: TestStartStop (1148.75s)
    --- FAIL: TestStartStop/group (0.00s)
        --- FAIL: TestStartStop/group/containerd (481.81s)

Unable to start VM: create: Error creating machine: Error in driver during machine creation: machine didn't return an IP after 120 seconds

        --- FAIL: TestStartStop/group/crio (458.93s)

                Error in configuration: context was not found for specified context: crio-20191126T214818.684992754-4983

VirtualBox_Linux

--- FAIL: TestDockerFlags (1305.81s)
                error execution phase certs/etcd-healthcheck-client: couldn't load CA certificate etcd-ca: failure loading etcd/ca certificate authority: failed to load certificate: the certificate is not valid yet

--- FAIL: TestStartStop (2696.89s)
    --- FAIL: TestStartStop/group (0.00s)
        --- FAIL: TestStartStop/group/containerd (697.79s)
        --- FAIL: TestStartStop/group/crio (2696.89s)

                The connection to the server 192.168.99.145:8444 was refused - did you specify the right host or port?