Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service: fix --url mode, add integration tests #5790

Merged
merged 5 commits into from
Oct 30, 2019
Merged

service: fix --url mode, add integration tests #5790

merged 5 commits into from
Oct 30, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Oct 30, 2019 •
edited
Loading

The service command was opening URL's, even if --url mode was specified. This was caused by a subtle regression in #5718

Fixes #5789

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2019
@tstromberg
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Oct 30, 2019
@tstromberg tstromberg mentioned this pull request Oct 30, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2019
@codecov-io
Copy link

Codecov Report

Merging #5790 into master will decrease coverage by 0.03%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5790      +/-   ##
==========================================
- Coverage   36.62%   36.58%   -0.04%     
==========================================
  Files         110      110              
  Lines        8093     8096       +3     
==========================================
- Hits         2964     2962       -2     
- Misses       4740     4745       +5     
  Partials      389      389
Impacted Files Coverage Δ
cmd/minikube/cmd/service.go 18.42% <0%> (-2.8%) ⬇️
pkg/minikube/service/service.go 76.75% <100%> (-0.25%) ⬇️

@tstromberg tstromberg merged commit cd19c51 into kubernetes:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retracile retracile retracile left review comments

@blueelvis blueelvis Awaiting requested review from blueelvis

@josedonizetti josedonizetti Awaiting requested review from josedonizetti

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

minikube service opens in browser when it should not
4 participants
@tstromberg @k8s-ci-robot @codecov-io @retracile