Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set --wait=false to default but still wait for apiserver #5757

Merged
merged 11 commits into from
Oct 29, 2019
Merged

Set --wait=false to default but still wait for apiserver #5757

merged 11 commits into from
Oct 29, 2019

Commits on Oct 28, 2019

  1. Wait for only apiserver by default 

    This PR changes --wait=false to be the default, but to still check for the apiserver in this case. If wait=true, we still wait for all pods to be up and running. This change should speed up `minikube start`, since we won't have to wait for other pods which can take a longer time to start up.

Ref kubernetes#5681
    Priya Wadhwa committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    7900b63 View commit details
    Browse the repository at this point in the history

  2. Remove extra log

    Priya Wadhwa committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    cf62ff6 View commit details
    Browse the repository at this point in the history

  3. Rebased on master

    Priya Wadhwa committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    f92b308 View commit details
    Browse the repository at this point in the history

  4. update start flags

    Priya Wadhwa committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    67901b4 View commit details
    Browse the repository at this point in the history

  5. make sure we can get api server pod

    Priya Wadhwa committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    993967b View commit details
    Browse the repository at this point in the history

  6. Add integration test 

    to make sure apiserver is up and running and that the pod can be
accessed via kubectl.
    Priya Wadhwa committed Oct 28, 2019
    Configuration menu
    Copy the full SHA
    c3dd5bc View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2019

  1. Update docs and add error message to generate-docs

    Priya Wadhwa committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    5f12e9a View commit details
    Browse the repository at this point in the history

  2. Update integration test name

    Priya Wadhwa committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    5113270 View commit details
    Browse the repository at this point in the history

  3. Clean up bootstrapper interface to accept list of pods to wait for 

    when waiting for the cluster to start up.
    Priya Wadhwa committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    f3b1a09 View commit details
    Browse the repository at this point in the history

  4. Remove additional docs

    Priya Wadhwa committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    c41eb8a View commit details
    Browse the repository at this point in the history

  5. improve comments

    Priya Wadhwa committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    bd5840a View commit details
    Browse the repository at this point in the history